update threejs

[SimonDanisch]

mrdoob/three.js#14598 got merged :)

[SimonDanisch]

bump
Don't want to be annoying, but I'm kind of excited to try this out! :)
After snooping around a bit, I couldn't really figure out where threejs actually get's loaded...
Is it as easy as changing this number?
https://github.com/rdeits/meshcat/blob/c97487125eb2bfd99b873ee7d487cae872f7b1fa/package.json#L17

[rdeits]

Yup, that's exactly right. You'll then need to re-generate the javascript bundle, which requires that you have npm installed. Full steps would be:

1. Install npm
2. Install yarn by running npm install -g yarn
3. cd into the meshcat folder (the same folder where package.json lives)
4. Instantiate your JS development environment by running yarn
5. Generate the new javascript bundle (and watch for future changes) by running npm run watch

Also, if you want to play around with the meshcat repo inside of MeshCat.jl, I'd suggest first running:

julia> MeshCat.develop_meshcat_assets()

which will convert the downloaded meshcat assets into a proper git submodule.

[SimonDanisch]

So how does this work, if there is no tagged version?

[rdeits]

Uh, that's a great question. Maybe https://docs.npmjs.com/files/package.json#git-urls-as-dependencies ?

[SimonDanisch]

Almost there:

sd@simondanisch:~/juliastuff/meshcat$ npm run watch
npm ERR! Linux 4.15.0-32-generic
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "watch"
npm ERR! node v8.10.0
npm ERR! npm  v3.5.2

npm ERR! missing script: watch
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /home/sd/juliastuff/meshcat/npm-debug.log

[rdeits]

Ah, sorry, "build" not "watch"

[ferrolho]

I have tested threejs r109 (ferrolho/meshcat@f020e53) and, at first sight, it does not seem to have breaking changes. Is there a reason for not upgrading?

[rdeits]

Nope, let's do it! I've made the necessary minor changes to meshcat over in meshcat-dev/meshcat#63 . I just need to test those changes against the Julia and Python clients, and then we should be good to go.

[ferrolho]

Three is now on r110 (https://www.npmjs.com/package/three). Would you like me to update my branch and create a new PR here?

[rdeits]

I included r110 in meshcat-dev/meshcat#63 so I think that should already cover it

[ferrolho]

It should; I failed to see meshcat-dev/meshcat#63 before. Thanks!