From 1ac8cc54bccf3947d9da6c0bc7a54b897f0cdb79 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 02:51:46 -0700 Subject: [PATCH 01/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .../release-automation/pre_release.rayci.yml | 110 +----------------- ci/ray_ci/automation/BUILD.bazel | 1 - 2 files changed, 2 insertions(+), 109 deletions(-) diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index 25fe2846b682c..63bf7b9ae0553 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -7,112 +7,6 @@ steps: job_env: forge instance_type: small_branch commands: - - bazel run //ci/ray_ci/automation:weekly_green_metric -- --check + - bazel build --build_python_zip //ci/ray_ci/automation:update_version + - bazel info bazel-bin - - label: "Check commit hash" - key: check-commit-hash - job_env: forge - depends_on: check-release-blockers - allow_dependency_failure: true - commands: - - bash .buildkite/release-automation/check-commit-hash.sh - - - label: "Trigger Postmerge test" - if: build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") != "1" - trigger: "postmerge" - key: trigger-postmerge - depends_on: check-commit-hash - build: - commit: "${BUILDKITE_COMMIT}" - branch: "${BUILDKITE_BRANCH}" - message: "Triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" - env: - RAYCI_RELEASE: 1 - RAYCI_FULL_PLATFORM_RELEASE: "${RAYCI_FULL_PLATFORM_RELEASE}" - - - label: "Trigger Postmerge nightly build & test" - if: build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") == "1" - trigger: "postmerge" - key: trigger-postmerge-nightly - depends_on: check-commit-hash - build: - commit: "${BUILDKITE_COMMIT}" - branch: "${BUILDKITE_BRANCH}" - message: "Triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" - env: - RAYCI_RELEASE: 1 - RAYCI_SCHEDULE: "nightly" - - - label: "Trigger Postmerge MacOS test" - key: trigger-postmerge-macos - trigger: "postmerge-macos" - depends_on: check-commit-hash - build: - commit: "${BUILDKITE_COMMIT}" - branch: "${BUILDKITE_BRANCH}" - message: "Triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" - env: - RAYCI_RELEASE: 1 - - - block: "Trigger Release nightly test" - if: build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") != "1" - key: block-release-nightly-test - depends_on: check-commit-hash - - - label: "Trigger Release nightly test" - key: trigger-release-nightly - trigger: "release" - depends_on: block-release-nightly-test - build: - commit: "${BUILDKITE_COMMIT}" - branch: "${BUILDKITE_BRANCH}" - message: "Nightly test - triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" - env: - AUTOMATIC: 1 - RELEASE_FREQUENCY: "nightly" - - - block: "Trigger Release nightly-3x test" - if: build.env("RAYCI_WEEKLY_RELEASE_NIGHLTY_3X") != "1" - key: block-release-nightly-3x-test - depends_on: check-commit-hash - - - label: "Trigger Release nightly-3x test" - key: trigger-release-nightly-3x - depends_on: block-release-nightly-3x-test - trigger: "release" - build: - commit: "${BUILDKITE_COMMIT}" - branch: "${BUILDKITE_BRANCH}" - message: "Nightly-3x test - triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" - env: - AUTOMATIC: 1 - RELEASE_FREQUENCY: "nightly-3x" - - - block: "Trigger Release weekly test" - if: build.env("RAYCI_WEEKLY_RELEASE_WEEKLY") != "1" - key: block-release-weekly-test - depends_on: check-commit-hash - - - label: "Trigger Release weekly test" - key: trigger-release-weekly - trigger: "release" - depends_on: block-release-weekly-test - build: - commit: "${BUILDKITE_COMMIT}" - branch: "${BUILDKITE_BRANCH}" - message: "Weekly test - triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" - env: - AUTOMATIC: 1 - RELEASE_FREQUENCY: "weekly" - - - label: "Check Ray commit in {{matrix}} nightly images" - key: check-ray-commit - if: build.branch !~ /^releases\// && build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") == "1" - depends_on: trigger-postmerge-nightly - allow_dependency_failure: true - job_env: forge - commands: - - bazel run //ci/ray_ci/automation:check_nightly_ray_commit -- --ray_type={{matrix}} --expected_commit="${BUILDKITE_COMMIT}" - matrix: - - ray - - ray-ml diff --git a/ci/ray_ci/automation/BUILD.bazel b/ci/ray_ci/automation/BUILD.bazel index 8dba953c1d22b..9bb47513872e9 100644 --- a/ci/ray_ci/automation/BUILD.bazel +++ b/ci/ray_ci/automation/BUILD.bazel @@ -92,7 +92,6 @@ py_test( py_binary( name = "update_version", srcs = ["update_version.py"], - exec_compatible_with = ["//:hermetic_python"], deps = [ ci_require("click"), ":update_version_lib", From eeea5bae97fc7029e9e20972fde958eee44a1826 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 03:02:32 -0700 Subject: [PATCH 02/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .buildkite/release-automation/pre_release.rayci.yml | 5 ++++- .buildkite/release-automation/test.sh | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100755 .buildkite/release-automation/test.sh diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index 63bf7b9ae0553..4cef696177314 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -8,5 +8,8 @@ steps: instance_type: small_branch commands: - bazel build --build_python_zip //ci/ray_ci/automation:update_version - - bazel info bazel-bin + - bash -i .buildkite/release-automation/test.sh + artifact_paths: + - "bazel-bin/ci/ray_ci/automation/update_version.zip" + - "ci/ray_ci/automation/update_version.zip" diff --git a/.buildkite/release-automation/test.sh b/.buildkite/release-automation/test.sh new file mode 100755 index 0000000000000..1bc7bf4cdbc4e --- /dev/null +++ b/.buildkite/release-automation/test.sh @@ -0,0 +1,3 @@ +OUTPUT_DIR="$HOME/.buildkite/ray/ci/ray_ci/automation/" +BUILD_OUTPUT="bazel-bin/ci/ray_ci/automation/update_version.zip" +cp $BUILD_OUTPUT $OUTPUT_DIR/ \ No newline at end of file From 1631d61199ddb27b4b78328ee23f036b1656cc2c Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 03:07:39 -0700 Subject: [PATCH 03/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .buildkite/release-automation/pre_release.rayci.yml | 3 --- .buildkite/release-automation/test.sh | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index 4cef696177314..7684c6cb7cdc4 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -9,7 +9,4 @@ steps: commands: - bazel build --build_python_zip //ci/ray_ci/automation:update_version - bash -i .buildkite/release-automation/test.sh - artifact_paths: - - "bazel-bin/ci/ray_ci/automation/update_version.zip" - - "ci/ray_ci/automation/update_version.zip" diff --git a/.buildkite/release-automation/test.sh b/.buildkite/release-automation/test.sh index 1bc7bf4cdbc4e..889732821ea1e 100755 --- a/.buildkite/release-automation/test.sh +++ b/.buildkite/release-automation/test.sh @@ -1,3 +1,3 @@ -OUTPUT_DIR="$HOME/.buildkite/ray/ci/ray_ci/automation/" +OUTPUT_DIR="/artifact-mount/.image-info/" BUILD_OUTPUT="bazel-bin/ci/ray_ci/automation/update_version.zip" cp $BUILD_OUTPUT $OUTPUT_DIR/ \ No newline at end of file From b4793f01f5ae53bcc5010feda2c5610744462030 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 03:14:13 -0700 Subject: [PATCH 04/12] slash Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .buildkite/release-automation/pre_release.rayci.yml | 1 - .buildkite/release-automation/test.sh | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index 7684c6cb7cdc4..f5cebe2dad4ae 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -9,4 +9,3 @@ steps: commands: - bazel build --build_python_zip //ci/ray_ci/automation:update_version - bash -i .buildkite/release-automation/test.sh - diff --git a/.buildkite/release-automation/test.sh b/.buildkite/release-automation/test.sh index 889732821ea1e..7796fa2699d86 100755 --- a/.buildkite/release-automation/test.sh +++ b/.buildkite/release-automation/test.sh @@ -1,3 +1,3 @@ -OUTPUT_DIR="/artifact-mount/.image-info/" +OUTPUT_DIR="/artifact-mount/" BUILD_OUTPUT="bazel-bin/ci/ray_ci/automation/update_version.zip" -cp $BUILD_OUTPUT $OUTPUT_DIR/ \ No newline at end of file +cp $BUILD_OUTPUT $OUTPUT_DIR \ No newline at end of file From a7f3f07bd08a0d2c3688660cfa01ee4063503af9 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 03:23:25 -0700 Subject: [PATCH 05/12] use pr Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .buildkite/release-automation/pre_release.rayci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index f5cebe2dad4ae..33cef0aded869 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -5,7 +5,7 @@ steps: - label: "Check release blockers" key: check-release-blockers job_env: forge - instance_type: small_branch + instance_type: default commands: - bazel build --build_python_zip //ci/ray_ci/automation:update_version - bash -i .buildkite/release-automation/test.sh From ccbfc793d4c75dffc55dcb6e5968e4c4a6e439e9 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 03:31:13 -0700 Subject: [PATCH 06/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- ci/ray_ci/automation/update_version.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ci/ray_ci/automation/update_version.py b/ci/ray_ci/automation/update_version.py index c7b65e2467d6b..663e7f672bb4d 100644 --- a/ci/ray_ci/automation/update_version.py +++ b/ci/ray_ci/automation/update_version.py @@ -7,22 +7,20 @@ update_file_version, ) -bazel_workspace_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") - - @click.command() +@click.option("--root_dir", required=True, type=str) @click.option("--new_version", required=True, type=str) -def main(new_version: str): +def main(root_dir: str, new_version: str): """ Update the version in the files to the specified version. """ - main_version, java_version = get_current_version(bazel_workspace_dir) + main_version, java_version = get_current_version(root_dir) update_file_version( main_version, java_version, new_version, - bazel_workspace_dir, + root_dir, ) From 5186cc8e1d4f26f83f29d56bc0015d9a3914ccd0 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 03:57:14 -0700 Subject: [PATCH 07/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .../release-automation/pre_release.rayci.yml | 117 +++++++++++++++++- ci/ray_ci/automation/BUILD.bazel | 1 + 2 files changed, 117 insertions(+), 1 deletion(-) diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index 33cef0aded869..0af97dab1a406 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -5,7 +5,122 @@ steps: - label: "Check release blockers" key: check-release-blockers job_env: forge + instance_type: small_branch + commands: + - bazel run //ci/ray_ci/automation:weekly_green_metric -- --check + + - label: "Check commit hash" + key: check-commit-hash + job_env: forge + depends_on: check-release-blockers + allow_dependency_failure: true + commands: + - bash .buildkite/release-automation/check-commit-hash.sh + + - label: "Build update version binary" + key: build-update-version-zip instance_type: default + job_env: forge commands: - bazel build --build_python_zip //ci/ray_ci/automation:update_version - - bash -i .buildkite/release-automation/test.sh + - cp bazel-bin/ci/ray_ci/automation/update_version.zip /artifact-mount/ + + - label: "Trigger Postmerge test" + if: build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") != "1" + trigger: "postmerge" + key: trigger-postmerge + depends_on: check-commit-hash + build: + commit: "${BUILDKITE_COMMIT}" + branch: "${BUILDKITE_BRANCH}" + message: "Triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" + env: + RAYCI_RELEASE: 1 + RAYCI_FULL_PLATFORM_RELEASE: "${RAYCI_FULL_PLATFORM_RELEASE}" + + - label: "Trigger Postmerge nightly build & test" + if: build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") == "1" + trigger: "postmerge" + key: trigger-postmerge-nightly + depends_on: check-commit-hash + build: + commit: "${BUILDKITE_COMMIT}" + branch: "${BUILDKITE_BRANCH}" + message: "Triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" + env: + RAYCI_RELEASE: 1 + RAYCI_SCHEDULE: "nightly" + + - label: "Trigger Postmerge MacOS test" + key: trigger-postmerge-macos + trigger: "postmerge-macos" + depends_on: check-commit-hash + build: + commit: "${BUILDKITE_COMMIT}" + branch: "${BUILDKITE_BRANCH}" + message: "Triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" + env: + RAYCI_RELEASE: 1 + + - block: "Trigger Release nightly test" + if: build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") != "1" + key: block-release-nightly-test + depends_on: check-commit-hash + + - label: "Trigger Release nightly test" + key: trigger-release-nightly + trigger: "release" + depends_on: block-release-nightly-test + build: + commit: "${BUILDKITE_COMMIT}" + branch: "${BUILDKITE_BRANCH}" + message: "Nightly test - triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" + env: + AUTOMATIC: 1 + RELEASE_FREQUENCY: "nightly" + + - block: "Trigger Release nightly-3x test" + if: build.env("RAYCI_WEEKLY_RELEASE_NIGHLTY_3X") != "1" + key: block-release-nightly-3x-test + depends_on: check-commit-hash + + - label: "Trigger Release nightly-3x test" + key: trigger-release-nightly-3x + depends_on: block-release-nightly-3x-test + trigger: "release" + build: + commit: "${BUILDKITE_COMMIT}" + branch: "${BUILDKITE_BRANCH}" + message: "Nightly-3x test - triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" + env: + AUTOMATIC: 1 + RELEASE_FREQUENCY: "nightly-3x" + + - block: "Trigger Release weekly test" + if: build.env("RAYCI_WEEKLY_RELEASE_WEEKLY") != "1" + key: block-release-weekly-test + depends_on: check-commit-hash + + - label: "Trigger Release weekly test" + key: trigger-release-weekly + trigger: "release" + depends_on: block-release-weekly-test + build: + commit: "${BUILDKITE_COMMIT}" + branch: "${BUILDKITE_BRANCH}" + message: "Weekly test - triggered by release-automation build #${BUILDKITE_BUILD_NUMBER}" + env: + AUTOMATIC: 1 + RELEASE_FREQUENCY: "weekly" + + - label: "Check Ray commit in {{matrix}} nightly images" + key: check-ray-commit + if: build.branch !~ /^releases\// && build.env("RAYCI_WEEKLY_RELEASE_NIGHTLY") == "1" + depends_on: trigger-postmerge-nightly + allow_dependency_failure: true + job_env: forge + commands: + - bazel run //ci/ray_ci/automation:check_nightly_ray_commit -- --ray_type={{matrix}} --expected_commit="${BUILDKITE_COMMIT}" + matrix: + - ray + - ray-ml diff --git a/ci/ray_ci/automation/BUILD.bazel b/ci/ray_ci/automation/BUILD.bazel index 9bb47513872e9..8dba953c1d22b 100644 --- a/ci/ray_ci/automation/BUILD.bazel +++ b/ci/ray_ci/automation/BUILD.bazel @@ -92,6 +92,7 @@ py_test( py_binary( name = "update_version", srcs = ["update_version.py"], + exec_compatible_with = ["//:hermetic_python"], deps = [ ci_require("click"), ":update_version_lib", From 1114da7bb7d3db552158b947d97fe61e7d1c1cc5 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 13:25:39 -0700 Subject: [PATCH 08/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .buildkite/release-automation/pre_release.rayci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/release-automation/pre_release.rayci.yml b/.buildkite/release-automation/pre_release.rayci.yml index 0af97dab1a406..acc24e7cf9812 100644 --- a/.buildkite/release-automation/pre_release.rayci.yml +++ b/.buildkite/release-automation/pre_release.rayci.yml @@ -22,7 +22,7 @@ steps: instance_type: default job_env: forge commands: - - bazel build --build_python_zip //ci/ray_ci/automation:update_version + - bazel build --build_python_zip --incompatible_use_python_toolchains=false --python_path=python //ci/ray_ci/automation:update_version - cp bazel-bin/ci/ray_ci/automation/update_version.zip /artifact-mount/ - label: "Trigger Postmerge test" From 4e6ea21e6860a6d0764209ced77ea1f17c0f889f Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Wed, 15 May 2024 13:35:05 -0700 Subject: [PATCH 09/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- .buildkite/release-automation/test.sh | 3 --- ci/ray_ci/automation/update_version.py | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) delete mode 100755 .buildkite/release-automation/test.sh diff --git a/.buildkite/release-automation/test.sh b/.buildkite/release-automation/test.sh deleted file mode 100755 index 7796fa2699d86..0000000000000 --- a/.buildkite/release-automation/test.sh +++ /dev/null @@ -1,3 +0,0 @@ -OUTPUT_DIR="/artifact-mount/" -BUILD_OUTPUT="bazel-bin/ci/ray_ci/automation/update_version.zip" -cp $BUILD_OUTPUT $OUTPUT_DIR \ No newline at end of file diff --git a/ci/ray_ci/automation/update_version.py b/ci/ray_ci/automation/update_version.py index 663e7f672bb4d..31b5353ff1405 100644 --- a/ci/ray_ci/automation/update_version.py +++ b/ci/ray_ci/automation/update_version.py @@ -1,5 +1,3 @@ -import os - import click from ci.ray_ci.automation.update_version_lib import ( @@ -7,6 +5,7 @@ update_file_version, ) + @click.command() @click.option("--root_dir", required=True, type=str) @click.option("--new_version", required=True, type=str) From 6ebbc1a25c22c4cb325fac9592c4f6335a891b9f Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Thu, 16 May 2024 00:45:30 -0700 Subject: [PATCH 10/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- ci/ray_ci/automation/update_version.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ci/ray_ci/automation/update_version.py b/ci/ray_ci/automation/update_version.py index 31b5353ff1405..3ee8d70007823 100644 --- a/ci/ray_ci/automation/update_version.py +++ b/ci/ray_ci/automation/update_version.py @@ -1,4 +1,6 @@ import click +import os +from typing import Optional from ci.ray_ci.automation.update_version_lib import ( get_current_version, @@ -7,12 +9,15 @@ @click.command() -@click.option("--root_dir", required=True, type=str) @click.option("--new_version", required=True, type=str) -def main(root_dir: str, new_version: str): +@click.option("--root_dir", required=False, type=str) +def main(new_version: str, root_dir: Optional[str] = None): """ Update the version in the files to the specified version. """ + if not root_dir: + root_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") + main_version, java_version = get_current_version(root_dir) update_file_version( From 36839761594abbf953c4a9004a4c24016afb0771 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Thu, 16 May 2024 00:47:21 -0700 Subject: [PATCH 11/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- ci/ray_ci/automation/update_version.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ci/ray_ci/automation/update_version.py b/ci/ray_ci/automation/update_version.py index 3ee8d70007823..65faf76291866 100644 --- a/ci/ray_ci/automation/update_version.py +++ b/ci/ray_ci/automation/update_version.py @@ -17,6 +17,8 @@ def main(new_version: str, root_dir: Optional[str] = None): """ if not root_dir: root_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") + if not root_dir: + raise Exception("Argument root_dir is not found.") main_version, java_version = get_current_version(root_dir) From 1713b7567f6a74e3e8376656d24a420cdd482a21 Mon Sep 17 00:00:00 2001 From: khluu <51931015+khluu@users.noreply.github.com> Date: Sun, 19 May 2024 22:44:18 -0700 Subject: [PATCH 12/12] p Signed-off-by: khluu <51931015+khluu@users.noreply.github.com> --- ci/ray_ci/automation/update_version.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/ray_ci/automation/update_version.py b/ci/ray_ci/automation/update_version.py index 65faf76291866..eec6aed47bfe7 100644 --- a/ci/ray_ci/automation/update_version.py +++ b/ci/ray_ci/automation/update_version.py @@ -16,9 +16,9 @@ def main(new_version: str, root_dir: Optional[str] = None): Update the version in the files to the specified version. """ if not root_dir: - root_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY", "") + root_dir = os.environ.get("BUILD_WORKSPACE_DIRECTORY") if not root_dir: - raise Exception("Argument root_dir is not found.") + raise Exception("Please specify --root_dir when not running with Bazel.") main_version, java_version = get_current_version(root_dir)