Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

OnClose event #10

Closed
egorzot opened this issue Oct 15, 2018 · 5 comments
Closed

OnClose event #10

egorzot opened this issue Oct 15, 2018 · 5 comments

Comments

@egorzot
Copy link

egorzot commented Oct 15, 2018

Description

Maybe It would be better if we have an OnClose event to handle menu closing?

close () {
  this.top = null;
  this.left = null;
  this.data = null;
  this.show = false;
  this.$emit('close');
},
@rawilk
Copy link
Owner

rawilk commented Oct 15, 2018

Good idea, I will implement this sometime when I get a chance to.

@egorzot
Copy link
Author

egorzot commented Oct 15, 2018

@rawilk can I send PR ?

@rawilk rawilk mentioned this issue Oct 15, 2018
@rawilk rawilk closed this as completed in 6b6dc05 Oct 15, 2018
@rawilk
Copy link
Owner

rawilk commented Oct 15, 2018

@egorzot - Thanks, but I already have the changes implemented since it was a small change. See PR #11.

@rawilk
Copy link
Owner

rawilk commented Oct 15, 2018

I did also add in the ability to listen for an open event on the menu in version 3.3.0, as I'm sure you'll see in the PR I made.

@egorzot
Copy link
Author

egorzot commented Oct 16, 2018

@rawilk thanks 👍 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants