From d5e98293c47c52aa306cf0be766e0b89772db72d Mon Sep 17 00:00:00 2001 From: James Swan <122404367+swan-amazon@users.noreply.github.com> Date: Fri, 10 Jan 2025 17:16:24 -0800 Subject: [PATCH] fix: Invert boolean return in GetAcknowledgementsRequest (#37014) * fix: Invert boolean return in GetAcknowledgementsRequest The GetAcknowledgementsRequest was returning an incorrect boolean value, causing unexpected behavior. This change inverts the return value to fix the logical error. Testing: - Issue identified during test plan script development - Test plan changes will be referenced in a separate change --- src/app/server/DefaultTermsAndConditionsProvider.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/server/DefaultTermsAndConditionsProvider.cpp b/src/app/server/DefaultTermsAndConditionsProvider.cpp index 36431aea456128..4a05a7d3ff8b87 100644 --- a/src/app/server/DefaultTermsAndConditionsProvider.cpp +++ b/src/app/server/DefaultTermsAndConditionsProvider.cpp @@ -211,7 +211,9 @@ CHIP_ERROR chip::app::DefaultTermsAndConditionsProvider::GetAcknowledgementsRequ TermsAndConditions requiredTermsAndConditions = requiredTermsAndConditionsMaybe.Value(); TermsAndConditions acceptedTermsAndConditions = acceptedTermsAndConditionsMaybe.Value(); - outAcknowledgementsRequired = requiredTermsAndConditions.Validate(acceptedTermsAndConditions); + + bool requiredTermsAndConditionsAreAccepted = requiredTermsAndConditions.Validate(acceptedTermsAndConditions); + outAcknowledgementsRequired = !requiredTermsAndConditionsAreAccepted; return CHIP_NO_ERROR; }