use shields.io directly for badge - fix #55

[balupton]

this redirect means that the badge will always benefit from the latest shields.io rendering code, to be consistent with other badges, rather than whatever outdated version of the code we cache within our app

[balupton]

would be nice to also amend this so that the query-string is also forwarded over, enabling shields.io badge customisations for free

[rauchg]

@balupton definitely interested in improving that. Only concern is the extra network hoop? Maybe we should proxy instead?

[balupton]

I wouldn't consider the extra network loop to be of significance to performance.

[rauchg]

But right now we have design parity and better performance? It's hard to give up on that. Maybe shields has a module we can reuse to serve it ourselves?

[balupton]

Well, I wouldn't say design parity, this fixes #55 for instance. Nor is their currently any parity with the other shields.io styling options available via an addition of query string forwarding. Meaning if the user wants to use a different style, and every other badge they use is with shields.io, the slack badge will stick out — another thing I face in the bevry and docpad projects that have been updated so far (we will eventually update all, of which there are about 200).

Also had a discussion here on shields about options: badges/shields#536

Regarding performance, I'd hardly say we have better performance, perhaps a few milliseconds... A common use case for this badge is in readmes, of which there will most likely be other hits to shields.io anyway, and I'd imagine their servers are better and perhaps have a caching thing for the specific url payload that we redirect to perhaps (this is all speculation though).

I think the ease of maintenance and automatically getting their updates is worth a few milliseconds performance degradation to be honest.

Although, if we get a shields.io module we can embed, that seems like the second best option to me.

[rauchg]

Fixed in 0.7.2.

[espadrine]

@rauchg Hello, shields.io author / maintainer here.

I might be reading this wrong, but it feels like you are not actually relying on the shields.io npm library (which, granted, is hard to find, thanks to complicated history). I would recommend using it in your case. See this for example code.

SVG has gone a long way since we started the projects (and given the number of bugs we raised to various browsers, I hope we helped a bit in making it easier to author it), but there are still a few pitfalls and incompatibilities that we worked on avoiding.

As a side-note, my understanding of Microsoft's Core Fonts' license is that it is not really legal to publish a copy of the Verdana font on a GitHub project (or in any public URL) without their consent.
As an aside to this side-note, I would recommend to use the TTF available on macOS by default, instead of the one available on Windows or on Linux' ttf-mscorefonts-installer package.

Alternatively, you may want to redirect to the shields.io website, by using its /badge/ endpoint, which would fix #73 for free.

Would you be interested by one of those choices? Would you consider a patch for it?

[devth]

Bump. I tried using style=flat-squared but it didn't seem to affect the style.