Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chart)!: accept IntoIterator for axis labels #1283

Merged
merged 5 commits into from
Aug 6, 2024
Merged

feat(chart)!: accept IntoIterator for axis labels #1283

merged 5 commits into from
Aug 6, 2024

Conversation

EdJoPaTo
Copy link
Contributor

@EdJoPaTo EdJoPaTo commented Aug 4, 2024

BREAKING CHANGES: #1273 is already breaking and this only advances the already breaking part

@EdJoPaTo
feat(chart)!: accept IntoIterator for labels
a989c5a 
BREAKING CHANGES: ratatui#1273 is already breaking and this only advances the already breaking part
@github-actions github-actions bot added the Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc. label Aug 4, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.5%. Comparing base (fe4eeab) to head (1361c37).

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #1283   +/-   ##
=====================================
  Coverage   94.5%   94.5%           
=====================================
  Files         65      65           
  Lines      15488   15492    +4     
=====================================
+ Hits       14637   14641    +4     
  Misses       851     851

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdJoPaTo EdJoPaTo mentioned this pull request Aug 4, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024 •
edited
Loading

🐰Bencher

ReportTue, August 6, 2024 at 09:17:33 UTC
ProjectRatatui
Branch1283/merge
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
barchart/render/2048➖ (view plot)194,330.00
barchart/render/256➖ (view plot)129,190.00
barchart/render/64➖ (view plot)86,453.00
barchart/render_grouped/2048➖ (view plot)342,390.00
barchart/render_grouped/256➖ (view plot)135,920.00
barchart/render_grouped/64➖ (view plot)124,770.00
barchart/render_horizontal/2048➖ (view plot)163,670.00
barchart/render_horizontal/256➖ (view plot)81,710.00
barchart/render_horizontal/64➖ (view plot)75,977.00
block/render_all_feature/100x50➖ (view plot)10,022.00
block/render_all_feature/200x50➖ (view plot)17,791.00
block/render_all_feature/256x256➖ (view plot)85,685.00
block/render_empty/100x50➖ (view plot)5,649.90
block/render_empty/200x50➖ (view plot)11,113.00
block/render_empty/256x256➖ (view plot)72,630.00
line_render/Center/0➖ (view plot)2.78
line_render/Center/10➖ (view plot)419.78
line_render/Center/3➖ (view plot)213.17
line_render/Center/4➖ (view plot)236.86
line_render/Center/42➖ (view plot)570.92
line_render/Center/6➖ (view plot)257.51
line_render/Center/7➖ (view plot)289.69
line_render/Left/0➖ (view plot)2.80
line_render/Left/10➖ (view plot)372.69
line_render/Left/3➖ (view plot)145.79
line_render/Left/4➖ (view plot)156.76
line_render/Left/42➖ (view plot)572.68
line_render/Left/6➖ (view plot)243.40
line_render/Left/7➖ (view plot)255.56
line_render/Right/0➖ (view plot)2.80
line_render/Right/10➖ (view plot)374.44
line_render/Right/3➖ (view plot)211.76
line_render/Right/4➖ (view plot)249.58
line_render/Right/42➖ (view plot)570.96
line_render/Right/6➖ (view plot)325.64
line_render/Right/7➖ (view plot)365.84
list/render/16384➖ (view plot)1,162,500.00
list/render/2048➖ (view plot)265,040.00
list/render/64➖ (view plot)145,240.00
list/render_scroll_half/16384➖ (view plot)1,156,200.00
list/render_scroll_half/2048➖ (view plot)266,250.00
list/render_scroll_half/64➖ (view plot)96,025.00
paragraph/new/2048➖ (view plot)250,850.00
paragraph/new/64➖ (view plot)6,252.40
paragraph/new/65535➖ (view plot)14,685,000.00
paragraph/render/2048➖ (view plot)439,730.00
paragraph/render/64➖ (view plot)401,390.00
paragraph/render/65535➖ (view plot)1,533,300.00
paragraph/render_scroll_full/2048➖ (view plot)388,270.00
paragraph/render_scroll_full/64➖ (view plot)425,150.00
paragraph/render_scroll_full/65535➖ (view plot)1,480,300.00
paragraph/render_scroll_half/2048➖ (view plot)389,370.00
paragraph/render_scroll_half/64➖ (view plot)437,140.00
paragraph/render_scroll_half/65535➖ (view plot)1,478,700.00
paragraph/render_wrap/2048➖ (view plot)240,330.00
paragraph/render_wrap/64➖ (view plot)194,610.00
paragraph/render_wrap/65535➖ (view plot)1,422,400.00
paragraph/render_wrap_scroll_full/2048➖ (view plot)239,700.00
paragraph/render_wrap_scroll_full/64➖ (view plot)195,550.00
paragraph/render_wrap_scroll_full/65535➖ (view plot)1,424,000.00
sparkline/render/2048➖ (view plot)120,540.00
sparkline/render/256➖ (view plot)119,350.00
sparkline/render/64➖ (view plot)38,087.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@EdJoPaTo EdJoPaTo changed the title feat(chart)!: accept IntoIterator for labels feat(chart)!: accept IntoIterator for axis labels Aug 4, 2024
@EdJoPaTo EdJoPaTo marked this pull request as ready for review August 4, 2024 13:31
@EdJoPaTo EdJoPaTo requested a review from a team as a code owner August 4, 2024 13:31
joshka
joshka approved these changes Aug 4, 2024
View reviewed changes
BREAKING-CHANGES.md Show resolved Hide resolved
@joshka
Copy link
Member

joshka commented Aug 4, 2024

Merge conflicts that need resolving to merge this.

@EdJoPaTo
Merge remote-tracking branch 'upstream/main' into chart-label-iterator
7e1b7ff 
Conflicts:
	BREAKING-CHANGES.md
	src/widgets/chart.rs
@EdJoPaTo EdJoPaTo mentioned this pull request Aug 5, 2024
Merged
@joshka
Copy link
Member

joshka commented Aug 6, 2024

This has merge conflicts (and allow edits by maintainers is turned off so we can't edit them on your behalf)

@EdJoPaTo EdJoPaTo merged commit afe1534 into ratatui:main Aug 6, 2024
38 of 39 checks passed
@EdJoPaTo EdJoPaTo deleted the chart-label-iterator branch August 6, 2024 09:39
joshka pushed a commit to erak/ratatui that referenced this pull request Oct 14, 2024
@EdJoPaTo @joshka
feat(chart)!: accept IntoIterator for axis labels (ratatui#1283)
d31bd70 
BREAKING CHANGES: ratatui#1273 is already breaking and this only advances the
already breaking part
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshka joshka joshka approved these changes

@kdheepak kdheepak kdheepak approved these changes

Assignees
No one assigned
Labels
Type: Breaking Change This change will cause application code to break and must be noted in the breaking changes docs etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdJoPaTo @joshka @kdheepak