fix(TestBackend): prevent area mismatch #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestBackend::new(400, 400)` resulted in a Rect with width/height 255,255 and a locally stored width/height of 400,400 which is wrong. `TestBackend::new` could have been fixed but this prevents this kind of error completely as its stored only at a single location now.
EdJoPaTo
requested review from
orhun,
joshka,
kdheepak and
Valentin271
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
=======================================
- Coverage 94.6% 94.6% -0.1%
=======================================
Files 65 65
Lines 15407 15402 -5
=======================================
- Hits 14576 14571 -5
Misses 831 831 ☔ View full report in Codecov by Sentry. |
|
Is this a breaking change? TestBackend implements serde derive. Reading from an older version should still work but reading from a newer version will not. |
joshka
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
I'm fine with generally breaking forwards compatibility without noting it as a breaking change in the conventional commit / BREAKING-CHANGES doc. Just make sure the commit (PR comment) calls it out so it gets called out in the changelog.
Ping @a-kenji for their thoughts on this, as the reason TestBackend supports serde is for the reasons mentioned is for an external testing lib mentioned in #389. I'm assuming that it's probably ok though, and if kenji doesn't have time to weigh on this, then we can go ahead and merge this as-is.
|
| Report | Fri, August 2, 2024 at 06:57:46 UTC |
| Project | Ratatui |
| Branch | 1252/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| barchart/render/2048 | ➖ (view plot) | 177,310.00 |
| barchart/render/256 | ➖ (view plot) | 114,790.00 |
| barchart/render/64 | ➖ (view plot) | 72,157.00 |
| barchart/render_grouped/2048 | ➖ (view plot) | 324,180.00 |
| barchart/render_grouped/256 | ➖ (view plot) | 121,380.00 |
| barchart/render_grouped/64 | ➖ (view plot) | 110,120.00 |
| barchart/render_horizontal/2048 | ➖ (view plot) | 157,430.00 |
| barchart/render_horizontal/256 | ➖ (view plot) | 74,674.00 |
| barchart/render_horizontal/64 | ➖ (view plot) | 68,600.00 |
| block/render_all_feature/100x50 | ➖ (view plot) | 8,808.90 |
| block/render_all_feature/200x50 | ➖ (view plot) | 15,736.00 |
| block/render_all_feature/256x256 | ➖ (view plot) | 70,994.00 |
| block/render_empty/100x50 | ➖ (view plot) | 4,513.80 |
| block/render_empty/200x50 | ➖ (view plot) | 8,927.90 |
| block/render_empty/256x256 | ➖ (view plot) | 58,401.00 |
| line_render/Center/0 | ➖ (view plot) | 2.78 |
| line_render/Center/10 | ➖ (view plot) | 399.57 |
| line_render/Center/3 | ➖ (view plot) | 216.89 |
| line_render/Center/4 | ➖ (view plot) | 238.54 |
| line_render/Center/42 | ➖ (view plot) | 493.33 |
| line_render/Center/6 | ➖ (view plot) | 249.43 |
| line_render/Center/7 | ➖ (view plot) | 280.81 |
| line_render/Left/0 | ➖ (view plot) | 2.79 |
| line_render/Left/10 | ➖ (view plot) | 353.39 |
| line_render/Left/3 | ➖ (view plot) | 145.47 |
| line_render/Left/4 | ➖ (view plot) | 154.04 |
| line_render/Left/42 | ➖ (view plot) | 493.73 |
| line_render/Left/6 | ➖ (view plot) | 236.11 |
| line_render/Left/7 | ➖ (view plot) | 244.68 |
| line_render/Right/0 | ➖ (view plot) | 2.78 |
| line_render/Right/10 | ➖ (view plot) | 356.59 |
| line_render/Right/3 | ➖ (view plot) | 218.60 |
| line_render/Right/4 | ➖ (view plot) | 253.74 |
| line_render/Right/42 | ➖ (view plot) | 493.10 |
| line_render/Right/6 | ➖ (view plot) | 332.11 |
| line_render/Right/7 | ➖ (view plot) | 363.39 |
| list/render/16384 | ➖ (view plot) | 1,144,400.00 |
| list/render/2048 | ➖ (view plot) | 255,860.00 |
| list/render/64 | ➖ (view plot) | 132,420.00 |
| list/render_scroll_half/16384 | ➖ (view plot) | 1,149,400.00 |
| list/render_scroll_half/2048 | ➖ (view plot) | 257,380.00 |
| list/render_scroll_half/64 | ➖ (view plot) | 90,286.00 |
| paragraph/new/2048 | ➖ (view plot) | 249,480.00 |
| paragraph/new/64 | ➖ (view plot) | 6,233.00 |
| paragraph/new/65535 | ➖ (view plot) | 14,369,000.00 |
| paragraph/render/2048 | ➖ (view plot) | 446,170.00 |
| paragraph/render/64 | ➖ (view plot) | 406,620.00 |
| paragraph/render/65535 | ➖ (view plot) | 1,422,400.00 |
| paragraph/render_scroll_full/2048 | ➖ (view plot) | 404,330.00 |
| paragraph/render_scroll_full/64 | ➖ (view plot) | 422,590.00 |
| paragraph/render_scroll_full/65535 | ➖ (view plot) | 1,379,900.00 |
| paragraph/render_scroll_half/2048 | ➖ (view plot) | 406,130.00 |
| paragraph/render_scroll_half/64 | ➖ (view plot) | 432,790.00 |
| paragraph/render_scroll_half/65535 | ➖ (view plot) | 1,385,800.00 |
| paragraph/render_wrap/2048 | ➖ (view plot) | 225,660.00 |
| paragraph/render_wrap/64 | ➖ (view plot) | 186,630.00 |
| paragraph/render_wrap/65535 | ➖ (view plot) | 1,418,300.00 |
| paragraph/render_wrap_scroll_full/2048 | ➖ (view plot) | 227,730.00 |
| paragraph/render_wrap_scroll_full/64 | ➖ (view plot) | 190,090.00 |
| paragraph/render_wrap_scroll_full/65535 | ➖ (view plot) | 1,419,100.00 |
| sparkline/render/2048 | ➖ (view plot) | 110,920.00 |
| sparkline/render/256 | ➖ (view plot) | 110,990.00 |
| sparkline/render/64 | ➖ (view plot) | 35,423.00 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
EdJoPaTo
added a commit
to EdJoPaTo/ratatui
that referenced
this pull request
Aug 2, 2024
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
Removes the height and width fields from TestBackend, which can get out of sync with the Buffer, which currently clamps to 255,255. This changes the `TestBackend` serde representation. It should be possible to read older data, but data generated after this change can't be read by older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestBackend::new(400, 400)resulted in a Rect with width/height 255,255 and a locally stored width/height of 400,400 which is wrong.TestBackend::newcould have been fixed, but this prevents this kind of error completely as its stored only at a single location now.Hint for
serdefeature users: TheTestBackendrepresentation changes. It should be able to read older data, but data generated after this change can't be read by older versions.