fix: only apply style to first line when rendering a Line
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `Line` widget should only apply its style to the first line when rendering and not the entire area. This is because the `Line` widget should only render a single line of text. This commit fixes the issue by clamping the area to a single line before rendering the text.
joshka
requested review from
orhun,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
=====================================
Coverage 94.6% 94.6%
=====================================
Files 65 65
Lines 15397 15407 +10
=====================================
+ Hits 14566 14576 +10
Misses 831 831 ☔ View full report in Codecov by Sentry. |
kdheepak
approved these changes
Jul 27, 2024
joshka
added a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
…1247) A `Line` widget should only apply its style to the first line when rendering and not the entire area. This is because the `Line` widget should only render a single line of text. This commit fixes the issue by clamping the area to a single line before rendering the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Linewidget should only apply its style to the first line whenrendering and not the entire area. This is because the
Linewidgetshould only render a single line of text. This commit fixes the issue by
clamping the area to a single line before rendering the text.