perf(list): avoid extra allocations when rendering List
#1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airblast-dev
requested review from
orhun,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
=====================================
Coverage 94.6% 94.6%
=====================================
Files 65 65
Lines 15397 15397
=====================================
Hits 14566 14566
Misses 831 831 ☔ View full report in Codecov by Sentry. |
kdheepak
approved these changes
Jul 26, 2024
orhun
approved these changes
Jul 26, 2024
orhun
changed the title
ListList
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
When rendering a `List`, each `ListItem` would be cloned. Removing the clone, and replacing `Widget::render` with `WidgetRef::render_ref` saves us allocations caused by the clone of the `Text<'_>` stored inside of `ListItem`. Based on the results of running the "list" benchmark locally; Performance is improved by %1-3 for all `render` benchmarks for `List`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a
List, eachListItemwould be cloned. Removing the clone, and replacingWidget::renderwithWidgetRef::render_refsaves us allocations caused by the clone of theText<'_>stored inside ofListItem.Based on the results of running the "list" benchmark locally; Performance is improved by %1-3 for all
renderbenchmarks forList.