fix(paragraph): Account for Block in Paragraphs line_width, and line_count methods. #1235
+261
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airblast-dev
requested review from
orhun,
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
======================================
Coverage 94.5% 94.5%
======================================
Files 65 65
Lines 15136 15276 +140
======================================
+ Hits 14305 14445 +140
Misses 831 831 ☔ View full report in Codecov by Sentry. |
joshka
approved these changes
Jul 22, 2024
joshka
approved these changes
Jul 23, 2024
|
I accidentally merged instead of rebasing and made a mess. There is also a missing semi-colon in one of the suggestions. Will clean up things locally and do a push. |
…count methods. Fixes: #1233
|
Things should be fixed now. Applied the suggestions, and made a few syntax fixes. I think this is good to go. |
joshka
approved these changes
Jul 23, 2024
joshka
pushed a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
…atui#1235) The `line_width`, and `line_count` methods for `Paragraph` would not take into account the `Block` if one was set. This will now correctly calculate the values including the `Block`'s width/height. Fixes: ratatui#1233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1233
The
line_width, andline_countmethods forParagraphwould not take into account theBlockif one was set. This will now correctly calculate the values including theBlock's width/height.The
Blocksnewly implementedhorizontal_space, andvertical_spacecan also be used inBlock::innersince its mostly duplicate logic. Can add it to this PR or a separate one later. This is also why I decided it would be better to return the results as(top, bottom), and(left, right)since it would allow for use in more areas.