Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): add GraphType::Bar #1205

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feat(chart): add GraphType::Bar #1205

merged 1 commit into from
Jul 16, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Jun 27, 2024

Demo

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.4%. Comparing base (3e7458f) to head (f6a5bcf).
Report is 10 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1205   +/-   ##
=====================================
  Coverage   94.4%   94.4%           
=====================================
  Files         62      62           
  Lines      15048   15092   +44     
=====================================
+ Hits       14217   14261   +44     
  Misses       831     831           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshka
Copy link
Member Author

joshka commented Jun 27, 2024

Inspired by btop, it might be nice to be able to have graphs that can be bar charts and not just lines / scatter.
image

@joshka joshka added the Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users label Jun 27, 2024
@joshka
Copy link
Member Author

joshka commented Jul 16, 2024

@ratatui-org/maintainers review-plz. This is a pretty small easy feature to approve.

@joshka joshka added the Effort: Easy Something that should be pretty quick to fix label Jul 16, 2024
@joshka joshka merged commit 5b51018 into main Jul 16, 2024
39 checks passed
@joshka joshka deleted the jm/barchart-chart branch July 16, 2024 03:47
@EdJoPaTo
Copy link
Contributor

We should get #1166 merged…

$ cargo semver-checks
     Parsing ratatui v0.27.0 (current)
      Parsed [  20.007s] (current)
     Parsing ratatui v0.27.0 (baseline)
      Parsed [  18.716s] (baseline)
    Checking ratatui v0.27.0 -> v0.27.0 (no change)
     Checked [   0.110s] 76 checks: 75 pass, 1 fail, 0 warn, 0 skip

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.33.0/src/lints/enum_variant_added.ron

Failed in:
  variant GraphType:Bar in …/ratatui/src/widgets/chart.rs:155

@EdJoPaTo EdJoPaTo removed Effort: Easy Something that should be pretty quick to fix Status: Review Needed PR needs a review / Issue needs buy-in from other maintainers / users labels Jul 31, 2024
@joshka
Copy link
Member Author

joshka commented Aug 2, 2024

Yeah, I think we actually need to mark a bunch of places as non-exhaustive like this where we might reasonably expect to add fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants