-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): add GraphType::Bar #1205
Conversation
joshka
commented
Jun 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
=====================================
Coverage 94.4% 94.4%
=====================================
Files 62 62
Lines 15048 15092 +44
=====================================
+ Hits 14217 14261 +44
Misses 831 831 ☔ View full report in Codecov by Sentry. |
@ratatui-org/maintainers review-plz. This is a pretty small easy feature to approve. |
We should get #1166 merged…
|
Yeah, I think we actually need to mark a bunch of places as non-exhaustive like this where we might reasonably expect to add fields. |