refactor: expand glob imports #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consensus is that explicit imports make it easier to understand the example code. This commit removes the prelude import from all examples and replaces it with the necessary imports, and expands other glob imports (widget::*, Constraint::*, KeyCode::*, etc.) in all the examples. See #1150 for more details.
joshka
requested review from
orhun,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
kdheepak
approved these changes
May 28, 2024
EdJoPaTo
suggested changes
May 28, 2024
|
Given that there are 4 warnings remaining when enabling (= removing the allow) of wildcard_imports (one in the examples), should it just be enabled in this PR too? Edit: 5 including https://github.com/ratatui-org/ratatui/blob/74a32afbaef8851f9462b27094d88d518e56addf/src/widgets/scrollbar.rs#L7 |
|
joshka
changed the title
…is large, and they are in the same file
EdJoPaTo
reviewed
May 29, 2024
EdJoPaTo
approved these changes
May 29, 2024
done and done. Also fixed a doc lint |
5 tasks
itsjunetime
pushed a commit
to itsjunetime/ratatui
that referenced
this pull request
Jun 23, 2024
Consensus is that explicit imports make it easier to understand the example code. This commit removes the prelude import from all examples and replaces it with the necessary imports, and expands other glob imports (widget::*, Constraint::*, KeyCode::*, etc.) everywhere else. Prelude glob imports not in examples are not covered by this PR. See ratatui#1150 for more details.
joshka
added a commit
to erak/ratatui
that referenced
this pull request
Oct 14, 2024
Consensus is that explicit imports make it easier to understand the example code. This commit removes the prelude import from all examples and replaces it with the necessary imports, and expands other glob imports (widget::*, Constraint::*, KeyCode::*, etc.) everywhere else. Prelude glob imports not in examples are not covered by this PR. See ratatui#1150 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consensus is that explicit imports make it easier to understand the
example code. This commit removes the prelude import from all examples
and replaces it with the necessary imports, and expands other glob
imports (widget::, Constraint::, KeyCode::*, etc.) everywhere else.
Prelude glob imports not in examples are not covered by this PR.
See #1150 for more details.