refactor: dont manually impl Default for defaults #1142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
impl Default
by#[derive(Default)]
when its implementation equals.Funny finding, the default Canvas doesn't use the default Marker:
https://github.com/ratatui-org/ratatui/blob/4f7791079edd16b54dc8cdfc95bb72b282a09576/src/widgets/canvas.rs#L621
https://github.com/ratatui-org/ratatui/blob/4f7791079edd16b54dc8cdfc95bb72b282a09576/src/symbols.rs#L489-L492