Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add hyperlink example #1063

Merged
merged 5 commits into from
Jun 17, 2024
Merged

docs(examples): add hyperlink example #1063

merged 5 commits into from
Jun 17, 2024

Conversation

joshka
Copy link
Member

@joshka joshka commented Apr 25, 2024

Demo

Proof of concept for: #1028

@joshka
Copy link
Member Author

joshka commented May 25, 2024

ping @ratatui-org/maintainers

@orhun
Copy link
Member

orhun commented May 26, 2024

Tested and works:

rec_20240526T205504

The 2-char hack felt a bit weird at first but I can't really think of something better that we can do here.

@joshka
Copy link
Member Author

joshka commented May 26, 2024

The 2-char hack felt a bit weird at first but I can't really think of something better that we can do here.

Fixing the parsing of ANSI inside the terminal / backend is the right fix. When that happens, this becomes a simpler example, but for now it documents the workaround.

Copy link
Member

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to have with its current state I think.

@joshka joshka merged commit 07efde5 into main Jun 17, 2024
33 checks passed
@joshka joshka deleted the jm/hyperlink branch June 17, 2024 22:11
itsjunetime pushed a commit to itsjunetime/ratatui that referenced this pull request Jun 23, 2024
joshka added a commit to erak/ratatui that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants