screenkey: unset XMODIFIERS to avoid XOpenIM err #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I know you're tired. So instead of asking you to do it I figured I'll propose a PR. Perhaps it's not as clean as it should be... In that case I'll just keep track of the status on GitHub and submit fixes until we get it right.
point is... on my setup this fails with
I resolved this in my old PR (NixOS#34898) by unsetting
XMODIFIERS
. UsingwrapProgram
, I kind of know how to do this the "right" way, but withwrapGAppsHook
I figured appending togappsWrapperArgs
would suffice even though there aren't any examples of unsetting variables this way in the entire nixpkgs repository so far... or my grep was lousy. So I don't really know if this is a clean way of doing this. I already mentioned this PR in NixOS#34167 so I'm counting on feedback soon enough.Things done
(nix.useChroot on NixOS,
or option
build-use-chroot
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)