Remove deprecated code blocks #5758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
force-pushed
the
removed-deprecated-classes
branch
from
bd26ea9 to
0a725f0
Compare
tmbo
force-pushed
the
removed-deprecated-classes
branch
from
bca842b to
0e71a97
Compare
tmbo
force-pushed
the
removed-deprecated-classes
branch
from
0e71a97 to
43e162a
Compare
…nto removed-deprecated-classes
tmbo
force-pushed
the
removed-deprecated-classes
branch
from
f8f2c9c to
1f8b9f3
Compare
alwx
suggested changes
May 19, 2020
| Removed previously deprecated classes: | ||
| - event brokers (``EventChannel`` and ``FileProducer``, ``KafkaProducer``, ``PikaProducer``, ``SQLProducer``) | ||
| - intent classifier ``EmbeddingIntentClassifier`` | ||
| - policy ``KerasPolicy`` |
There was a problem hiding this comment.
Should some information about that also be added to the Migration Guide? It currently has some information about KerasPolicy and EmbeddingIntentClassifier deprecation, but nothing about the fact that these classes are removed in the new version.
There was a problem hiding this comment.
yes that is a good point - will add something 👍
Co-authored-by: Alexander Pantiukhov <[email protected]>
Co-authored-by: Alexander Pantiukhov <[email protected]>
tmbo
commented
May 21, 2020
tmbo
commented
May 21, 2020
|
ready for another review 💯 |
alwx
approved these changes
May 26, 2020
indam23
pushed a commit
that referenced
this pull request
Jul 27, 2022
* removed deprecated brokers2 * removed deprecated code and fixed regex featurizer * working on fixing tests * working on fixing tests * fixed test * fixed documentation build * working on fixing the tests * removed restaurantbot example * improved testing speed by using caching and avoiding duplicated model loads * reverted some unneeded changes * trying to fix tests * fix moodbot model race condition in tests * removed randomly failing test * removed remaining instaces of EmbeddingPolicy * Update changelog/5834.removal.rst Co-authored-by: Alexander Pantiukhov <[email protected]> * Update rasa/utils/common.py Co-authored-by: Alexander Pantiukhov <[email protected]> * Update docs/core/policies.rst * Update tests/cli/test_cli.py * added information to migration guide Co-authored-by: Alexander Pantiukhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
doctoconly runs on the readmeEventChannelandFileProducer,KafkaProducer,PikaProducer,SQLProducer)EmbeddingIntentClassifieruseDIETClassifiereverywhereKerasPolicyuseTEDPolicyeverywhereAgent.handle_channelsTrackerStore.create_tracker_storeConvertFeaturizerto avoid loading pretrained tensorflow models multiple times (will now use the model loaded byConvertTokenizer)entity_examplesandintent_examplessection in training dataHFTransformerandConvertTokenizerto speed up testing@mock_s3annotation as it would not run the test (somehow the async would not get picked up)closes #5178
Status (please check what you already did):
black(please check Readme for instructions)