-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input dropout #5636
Input dropout #5636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a changelog so that we can find this change later again.
@dakshvar22 @tabergma do we want to merge this one? |
@Ghostvv As discussed, can you test it on a couple of datasets and configs before merging it? |
Co-Authored-By: Daksh Varshneya <[email protected]>
This also requires retraining of models, doesn't it? Should we increase the minimum model version number and add a note to the changelog entry? Or should we push it to master so that we release it with the next minor? |
this one doesn't because dropout is turned off during prediction so prediction graph is the same |
but maybe merging it into master is safer bet |
let's merge 1.9.x in a separate PR first: #5660 |
I added a parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would require increasing the minimum compatible version right? Since we added a new layer by default, it would be a model breaking version I guess.
it needs to increase anyhow, since master is not compatible with 1.9, but I don't think it requires here, since dropout doesn't affect prediction graph |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)