add regular vulnerability scan #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
force-pushed
the
docker-analysis
branch
6 times, most recently
from
33b5e2b to
a355233
Compare
tmbo
requested changes
Apr 15, 2020
| - name: Get latest tagged Rasa Open Source version 🔎 | ||
| # We only scan the latest stable version of the Rasa Open Source Image | ||
| run: | | ||
| git fetch --depth=1 origin "+refs/tags/*:refs/tags/*" |
There was a problem hiding this comment.
why should this run the tag and not just the master branch?
There was a problem hiding this comment.
You mean against latest (I'd like to avoid re-building the docker images) ? Can do, then we are dependent that changes from the patch branches are merged to master asap (which should be done anyway).
wochinge
force-pushed
the
docker-analysis
branch
from
a1548c8 to
c0ec842
Compare
|
Something changed in ruamel.yaml |
|
😂 💩 |
|
@alwx Could you please have a short look on the latest commit? |
|
Does 👍 mean the change is ok, or that you will have a look? 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
TODO:
ruamel.yamldependency https://github.com/RasaHQ/rasabaster/pull/70 due to this error https://nvd.nist.gov/vuln/detail/CVE-2019-20478#VulnChangeHistorySection (Trivy didn't find this. They are also working on including the GitHub database, which hopefully makes the detection better (Is it good to depend on safety-db for Python vuln DB? aquasecurity/trivy#344))Status (please check what you already did):
black(please check Readme for instructions)