Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "confused_with" & confusion matrix to response selector evaluation #5544

Merged
merged 8 commits into from
Apr 7, 2020

Conversation

hotzenklotz
Copy link
Contributor

@hotzenklotz hotzenklotz commented Mar 31, 2020

Proposed changes:

  • Similar to the intent evaluation reports, I added the "confused_with" attribute to the response_selection_report.json
  • Also similar to intent evaluation, I added a plot of the confusion matrix for response selection evaluation

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

…/rasa into response-selection-confusion

* 'response-selection-confusion' of github.com:hotzenklotz/rasa:
  prepared release of version 1.9.4
  make it a bugfix
  add changelog and a comment
  remove comments
  removed call to generator in predict
  change enum of subitems
  change enum of subitems
  change enum of subitems
  change enum of subitems
  Update release documentation
  Update release documentation
  Update release documentation
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from amn41 April 1, 2020 06:00
Copy link
Contributor

@amn41 amn41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, nice addition thanks!

@hotzenklotz
Copy link
Contributor Author

@amn41 Thanks for the approval. What are the next steps for being merged?

@amn41 amn41 merged commit 88f94ca into RasaHQ:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants