Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RabbitMQ 'queue' argument usage #5492

Merged
merged 3 commits into from
Mar 25, 2020
Merged

fix RabbitMQ 'queue' argument usage #5492

merged 3 commits into from
Mar 25, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Mar 25, 2020 •
edited
Loading

Proposed changes:

  • since there was a default value for the queues argument and a queues argument takes precedence over a potentially specified queue argument, the queue argument was always ignored
  • long story short: Rasa sent events to the wrong queue when using the old queue argument

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge changed the base branch from master to 1.9.x March 25, 2020 18:48
@wochinge wochinge requested review from ricwo and alwx March 25, 2020 18:52
ricwo
ricwo approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for fixing - looks great 👍

@wochinge wochinge force-pushed the pika-old-queue-arg-fix branch from 6b016fc to 985052e Compare March 25, 2020 19:11
@wochinge wochinge merged commit 0202fe9 into 1.9.x Mar 25, 2020
@wochinge wochinge deleted the pika-old-queue-arg-fix branch March 25, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

@alwx alwx Awaiting requested review from alwx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @ricwo