-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to TF 2.0 and new NLU components #5266
Conversation
I don't think doubling the test time is something we can accept - I do not think we should merge this before looking into this. |
Just had a glimpse, but we should add docstrings to at least all classes and public functions / methods |
Created some issues to tackle remaining cleanup tasks after the merge: |
@wochinge regarding attributes: we kept the way it was done before, just substituted magic strings with constants. I agree it is not very clear from the constants how they are used, but as soon as you see then in context, in my opinion it is quite clear, and additional wording just make it more complicated. I agree that the whole message attribute logic is not very intuitive, but changing it is out of the scope of this |
alt_requirements/requirements_pretrained_embeddings_convert.txt
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tobias Wochinger <[email protected]>
- It's possible now to specify region name for AWS S3 - Tests are setting mock region name now
how to use bert chinese |
@suzhaomin666 Please ask questions in the Rasa Forum. This link should hopefully also help you: https://rasa.com/docs/rasa/nlu/components/#hftransformersnlp |
@suzhaomin666 This link should hopefully also help you: https://github.com/lhr0909/rasa-v2-nlu-bert-chinese |
Proposed changes:
DIETClassifier
CRFEntityExtractor
andKerasPolicy
(We still need to finish up some parts of the documentation and some minor changes inside the code itself. Test time has increased quite a bit and we will try to reduce it, but this is not our highest priority for now. This can be also tackled after the merge if needed.)
Status (please check what you already did):
black
(please check Readme for instructions)