Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with latest distributed #869

Closed
quasiben opened this issue Mar 7, 2022 · 2 comments
Closed

Test failure with latest distributed #869

quasiben opened this issue Mar 7, 2022 · 2 comments

Comments

@quasiben
Copy link
Member

quasiben commented Mar 7, 2022

With dask/distributed#5814 merged in, the test_proxify_host_file.py::test_worker_force_spill_to_disk test currently fails test fails in due to assertion in distributed: https://github.com/dask/distributed/blob/39c5e8856cb05ad1833a0f6ee6c3fea0ddab1c1c/distributed/worker.py#L3882-L3884

self.data is <class 'dask_cuda.proxify_host_file.ProxifyHostFile'> and SpillBuffer is its own type. It seems like we could either ask why the assertion is necessary or subclass spillbuffer for ProxifyHostFile

cc @madsbk

@pentschev
Copy link
Member

Sorry, only saw this now. I believe this is a breaking change from Distributed for us, I filed dask/distributed#5909 as well.

@jakirkham
Copy link
Member

Think this was fixed by PR ( dask/distributed#5904 ) included in distributed version 2022.03.0. Going to go ahead and close this out, but please feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants