From a53b3fd240bc16884ef0da58b6b38871d571cd10 Mon Sep 17 00:00:00 2001
From: Raphael Ahrens <raphaelahrens@googlemail.com>
Date: Wed, 13 Mar 2024 17:18:45 +0100
Subject: [PATCH] Added a first draft for #234

In #234 @colesmj suggested to move the import of pydal into the sqlDumb
function.
This commit does this and if the import fails raises an UIError with an
explanation on how to proceed.
The text is just a first draft.

To move the import the function get_table was also moved inside the
sqlDump function.
---
 pytm/pytm.py | 34 +++++++++++++++++++++-------------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/pytm/pytm.py b/pytm/pytm.py
index 9906648..632c144 100644
--- a/pytm/pytm.py
+++ b/pytm/pytm.py
@@ -21,8 +21,6 @@
 from weakref import WeakKeyDictionary
 from datetime import datetime
 
-from pydal import DAL, Field
-
 from .template_engine import SuperFormatter
 
 """ Helper functions """
@@ -1173,6 +1171,25 @@ def _stale(self, days):
         return ""
 
     def sqlDump(self, filename):
+        try:
+            from pydal import DAL, Field
+        except ImportError as e:
+            raise UIError(
+                e, """This feature requires the pyDAL package,
+    Please install the package via pip or your packagemanger of choice.
+                """
+            )
+
+        @lru_cache(maxsize=None)
+        def get_table(db, klass):
+            name = klass.__name__
+            fields = [
+                Field("SID" if i == "id" else i)
+                for i in dir(klass)
+                if not i.startswith("_") and not callable(getattr(klass, i))
+            ]
+            return db.define_table(name, fields)
+
         try:
             rmtree("./sqldump")
             os.mkdir("./sqldump")
@@ -1199,10 +1216,10 @@ def sqlDump(self, filename):
             Data,
             Finding,
         ):
-            self.get_table(db, klass)
+            get_table(db, klass)
 
         for e in TM._threats + TM._data + TM._elements + self.findings + [self]:
-            table = self.get_table(db, e.__class__)
+            table = get_table(db, e.__class__)
             row = {}
             for k, v in serialize(e).items():
                 if k == "id":
@@ -1212,15 +1229,6 @@ def sqlDump(self, filename):
 
         db.close()
 
-    @lru_cache(maxsize=None)
-    def get_table(self, db, klass):
-        name = klass.__name__
-        fields = [
-            Field("SID" if i == "id" else i)
-            for i in dir(klass)
-            if not i.startswith("_") and not callable(getattr(klass, i))
-        ]
-        return db.define_table(name, fields)
 
 
 class Controls: