Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding annotations to PSPs #1512

Closed
deniseschannon opened this issue Aug 3, 2021 · 4 comments
Closed

Adding annotations to PSPs #1512

deniseschannon opened this issue Aug 3, 2021 · 4 comments
Labels
kind/bug Something isn't working kind/dev-validation Dev will be validating this issue

Comments

@deniseschannon
Copy link

Based on the Rancher integration with it's own ability to manage PSP templates, Rancher is requesting that the PSPs have annotations that match the namespace annotation, so that these PSPs can be identified and deleted when a user selects a default PSP from Rancher.

We'd like to use the following annotations (which are the same ones in the namespace), but have them on the actual PSP as well.

psp.rke2.io/global-restricted or psp.rke2.io/global-unrestricted

@briandowns
Copy link
Contributor

This has been resolved in master and the release-1.21 branches.

@deniseschannon
Copy link
Author

The Rancher requirements have been met, so I'm not clear if this ticket still needs to be open?

@briandowns
Copy link
Contributor

briandowns commented Sep 1, 2021

I think we need to keep it open for QA to validate as part of their process for the 1.22 release.

@briandowns
Copy link
Contributor

Validated on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/dev-validation Dev will be validating this issue
Projects
None yet
Development

No branches or pull requests

6 participants