From c4e428e47e676534ae47f28369a8fbdff9ce8b92 Mon Sep 17 00:00:00 2001 From: Daishan Peng Date: Wed, 27 Dec 2017 15:02:16 -0700 Subject: [PATCH] don't set finalize on namespace --- lifecycle/object.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lifecycle/object.go b/lifecycle/object.go index 349dd1115..796409e48 100644 --- a/lifecycle/object.go +++ b/lifecycle/object.go @@ -141,7 +141,9 @@ func (o *objectLifecycleAdapter) create(metadata metav1.Object, obj runtime.Obje metadata.SetAnnotations(map[string]string{}) } - metadata.SetFinalizers(append(metadata.GetFinalizers(), o.name)) + if o.objectClient.GroupVersionKind().Kind != "Namespace" { + metadata.SetFinalizers(append(metadata.GetFinalizers(), o.name)) + } metadata.GetAnnotations()[initialized] = "true" _, err = o.objectClient.Update(metadata.GetName(), obj)