Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply resource limit to fetch request #6682

Closed
nwmac opened this issue Aug 18, 2022 · 2 comments
Closed

Apply resource limit to fetch request #6682

nwmac opened this issue Aug 18, 2022 · 2 comments

Comments

@nwmac
Copy link
Member

nwmac commented Aug 18, 2022

We added a resource limit which is currently only used for events.

We still fetch all of the resources and then apply the limit - we should apply the limit to the API request, so we only fetch at most the number specified by the limit.

Need to make sure this works with incremental loading.

@nwmac nwmac added this to the v2.7.0 milestone Aug 18, 2022
@nwmac nwmac self-assigned this Aug 18, 2022
@nwmac nwmac added [zube]: Backlog size/1 Size Estimate 1 labels Aug 18, 2022
@gaktive gaktive modified the milestones: v2.7.0, v2.7.1 Sep 14, 2022
@gaktive gaktive modified the milestones: v2.7.2, v2.7.1 Oct 5, 2022
@gaktive
Copy link
Member

gaktive commented Jan 10, 2023

Pushing out but there may be additional work in #7871 to look at.

@gaktive gaktive modified the milestones: v2.7.next1, v2.7.next2 Jan 10, 2023
@gaktive gaktive modified the milestones: v2.7.next2, v2.7.next3 Apr 11, 2023
@nwmac nwmac modified the milestones: v2.7.next3, v2.7.next4 Jun 8, 2023
@gaktive gaktive modified the milestones: v2.8.0, v2.8.next1 Aug 3, 2023
@nwmac
Copy link
Member Author

nwmac commented Aug 16, 2023

Not needed here when we add server-side pagination - won't fix

@nwmac nwmac modified the milestones: v2.8.next1, v2.8.0 Aug 16, 2023
@nwmac nwmac closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants