Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Fix missing label attribute issue with form input control #12818

Open
Tracked by #7968
nwmac opened this issue Dec 5, 2024 · 1 comment · Fixed by #13293
Open
Tracked by #7968

a11y: Fix missing label attribute issue with form input control #12818

nwmac opened this issue Dec 5, 2024 · 1 comment · Fixed by #13293
Labels
area/accessibility kind/enhancement priority/1 QA/manual-test Indicates issue requires manually testing size/0.5 Size Estimate 0.5
Milestone

Comments

@nwmac
Copy link
Member

nwmac commented Dec 5, 2024

a11y issue: 86

Issue 86 - Missing form label or 'title' attribute

The form field do not have the label associated with them and "title" attribute is not included in their source code either resulting in screen reader users fail to understand the purpose of the form field.

This should be fixed in the form input control(s).

This appears in several places:

Account and API Keys

  • API key section
  • Filter input field

Projects/Namespaces

  • Filter input field

Import YAML

  • Type Import YAML data textarea

Example:

image

Suggested remediation:

Apply the following changes:
• Provide unique and descriptive visual label for the mentioned form fields using tag.
• Use "for" and "id" attributes to associate labels with their respective form fields. Ensure that the value of "for" attribute of the label exactly matches the value of "id" attribute of the form field.

@nwmac nwmac added this to the v2.11.0 milestone Dec 5, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 5, 2024
@yonasberhe23 yonasberhe23 added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Feb 6, 2025
@yonasberhe23
Copy link
Contributor

Requires manual validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility kind/enhancement priority/1 QA/manual-test Indicates issue requires manually testing size/0.5 Size Estimate 0.5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants