Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highcharts Editor Replacement #8

Open
25 tasks
dan-bowerman opened this issue Aug 6, 2024 · 5 comments
Open
25 tasks

Highcharts Editor Replacement #8

dan-bowerman opened this issue Aug 6, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@dan-bowerman
Copy link
Member

dan-bowerman commented Aug 6, 2024

High-level requirements (culled from capabilities pre-existing in https://editor.highcharts.com/full.html):

  • Ability to preview charts while they are being developed
  • Ability to Paste in tabular data
  • Ability to Import a properly formatted CSV
  • *Ability to Develop English and French simultaneously (like RAMP4 editor)
  • Option to import existing Highcharts JSON configuration
  • Option to Export as Highcharts JSON configuration
  • Field to input a Chart title
  • Field to input a Chart sub-title
  • Field to input Data Series configs: Color, color by point, dash style, enable point markers?, marker symbol
  • Field to input a Y-axis title
  • Field to input a X-axis title (if needed)

Chart/Series types - Keep it basic on the first pass, add more types as demand dictates:

  • Bar
  • Column
  • Line
  • Scatter
  • Any combination of the above*
  • Pie (does not combine}

Things we could hardcode/make default:

  • Filename*
  • Width, height, zoom: auto
  • Fonts and styles
  • Value labels
  • Legends
  • Number formatting
  • Export button and menu (localization)
  • Disable credits/Highcharts attribution

Other considerations:

  • Needs a fun acronym?
  • An "Advanced" config editor to allow straight JSON manipulation?
  • This may want its own repo? Do we want it to be standalone outside of RESPECT?
  • Look and feel should be similar to the RAMP4 config-editor, but consultation with UX Team is advised.
  • Should be fully WCAG "AA" compliant.

* Needs further discussion

@dan-bowerman dan-bowerman added the enhancement New feature or request label Aug 6, 2024
@dan-bowerman
Copy link
Member Author

Related ramp4-pcar4/storylines-editor#359

@yileifeng
Copy link
Member

List looks good to me and includes all of the core functionality. Having an advanced editor (similar to what we have for slides) seems like a good idea to cover any gaps from missing advanced functionality such as secondary axis positioning, tooltip/legend formatting, etc. The consideration for integrating an advanced editor would involve drafting up a comprehensive Highcharts schema for validation.

@james-rae
Copy link
Member

This may want its own repo? Do we want it to be standalone outside of RESPECT?

I remember someone mentioning in a meeting that general real-world users of the current highcharts editor were awfully unhappy due to the lack of support.

Having this as a stand-alone might have a lot of use for a lot of people (and maybe even a few of them discover their StoryRamp dreams can come true). On the flipside, if this does become popular, one can expect all sorts of issues being logged, requests for new features, and the obligatory grouses and unpleasantness of anything public. I can't see many asks getting prioritized unless it's something also benefiting our projects.

Anyway, could be...interesting.

@abooalir
Copy link

abooalir commented Sep 25, 2024

Hello everyone. We have some questions regarding the Highcharts requirements:

  • For the chart types, are you looking to only have the basic option for each type, or do you also want us to consider the different styles of that chart similar to Highcharts?
    Screenshot 2024-09-20 133249

  • With regards to importing Highcharts as JSON configuration, will the user be allowed to upload a .JSON file or copy and paste into an editor or both?

  • Just to confirm, if the user uploads a new data file, is the expected behaviour to replace any existing imported data?

  • What are the formats the user can export the data as?

We would really appreciate your clarification on these matters. Thank you in advance.

@dan-bowerman
Copy link
Member Author

For the chart types, are you looking to only have the basic option for each type, or do you also want us to consider the different styles of that chart similar to Highcharts?

I think just the basics for this first phase. We can get very bogged down with supporting the vast selection of chart types and options for them, but at the end of the day, 99% of the charts our clients are going to be developing will be basic, or combinations of basic types. Folks will be able to manually construct and import "fancy" charts using the other chart types available if they desire.

With regards to importing Highcharts as JSON configuration, will the user be allowed to upload a .JSON file or copy and paste into an editor or both?

Both would be preferred. To my point above, a client may use the Highcharts editor on the side if they so desire, and they could import the file exported from that tool, or paste it in directly.

Just to confirm, if the user uploads a new data file, is the expected behaviour to replace any existing imported data?

The Storylines Editor's current implementation requires a user to create a blank chart, and from there they can work with the H.E.R. charts editor directly, or import an existing configuration. Given the context they are working in, I believe it makes sense to overwrite that selected chart if they're importing a configuration.

What are the formats the user can export the data as?

Export in this context means to output the generated JSON output of the Highcharts Editor such that it could be leveraged in other Storylines products or the original Highcharts Editor. It would be a .JSON file that is downloaded to the user's device.

Hope this clarifies things, please reach out if you have any more questions!

@yileifeng yileifeng transferred this issue from ramp4-pcar4/storylines-editor Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants