Docupdates #29
Merged
Docupdates #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also this is my first real pull request to someone else's repo so if I need to do something differently please let me know |
|
|
||
| The 4th parameter is a selection query for determining who the message should be sent to. This query can be one of the three following items: | ||
| * `query` : {} or {userId : 'XXXXX'} or {id : 'XXXXX'} |
There was a problem hiding this comment.
if possible id also do around the json objects. like so:
{} or {userId : 'XXXXX'} or {id : 'XXXXX'}
|
thanks for doing this. lets hope @raix pulls it in |
raix
pushed a commit
that referenced
this pull request
Jan 21, 2015
Documentation updates by @funkyeah
|
Super @funkyeah looks good! Its a huge help to the community - I know too much of the internals and taking "stuff" for granted, so I'm not the best to write docs I think :) |
|
@alexcorre thanks for review, awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raix hopefully pull requesting suitable documentation updates to add more details around Push.send and its parameters. I am not 100% sure that what I am saying is even correct so I think it would be worth a quick read through from your side.