Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect flashes broken #3053

Closed
dansteele opened this issue Aug 8, 2018 · 2 comments
Closed

Redirect flashes broken #3053

dansteele opened this issue Aug 8, 2018 · 2 comments

Comments

@dansteele
Copy link

Howdy,

After upgrading from v1.3.0 to 1.4.0, my flashes on redirect seem to have broken throughout my application, not limited to the engine itself.

No matter how I try and set the flashes (flash[:notice] = or redirect_to my_url, notice: 'hello'), they only seem to appear when the back button is used on the redirected-to page.

Tested on Rails 5.2.0, Rails 5.2.1, and using jquery-ui-rails 5.0.5 and 6.0.1

Keeping this gem at v1.3.0 for now

@wlipa
Copy link

wlipa commented Aug 8, 2018

Might be to do with the flash middleware and #3048

@mshibuya
Copy link
Member

mshibuya commented Feb 9, 2019

I guess so, closing this.

@mshibuya mshibuya closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants