Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade documentation typo on Section 3 #76

Closed
stevegeek opened this issue Feb 23, 2022 · 2 comments
Closed

Upgrade documentation typo on Section 3 #76

stevegeek opened this issue Feb 23, 2022 · 2 comments

Comments

@stevegeek
Copy link
Contributor

stevegeek commented Feb 23, 2022

Hi! I was just following the sprockets upgrade guide and spotted a typo:

On Section 3, step 1, it says Replace 'sass-rails' with 'propshaft'; - guess this should be Replace 'sprockets-rails' with 'propshaft';?

Also, in case its useful for future docs:

while this guide is clearly about Sprockets -> propshaft, I was moving from a webpacker with no sprockets-rails setup, in which case if you first remove webpacker (Steps 1/2 on Section 1) it is not possible to run the jsbundling-rails install script on Step 3 as Rails will fail to boot with NoMethodError: undefined method 'assets' for #<Rails::Application::Configuration if the environment contains any assets config. So need to do the install before removing webpacker or add the sprockets railtie temporarily.

Just finished migrating a large app to js/cssbundling-rails & propshaft 🎉 Thanks!

@brenogazzola
Copy link
Collaborator

brenogazzola commented Feb 23, 2022

On Section 3, step 1, it says Replace 'sass-rails' with 'propshaft'; - guess this should be Replace 'sprockets-rails' with 'propshaft';?

Nope. It's really sass-rails. An app running the standard Sprockets for CSS, Webpacker for JS will have sass-rails in its Gemfile, not sprockets-rails.

While this guide is clearly about Sprockets -> propshaft, I was moving from a webpacker with no sprockets-rails setup

We could use another upgrade guide, for someone who is fully on Webpacker, instead of Sprockets/Webpacker. Would you mind opening a PR for that? I think you could duplicate the current guide and remove things you didn't need, update the ones that were different, and add the ones that were not mentioned.

@stevegeek
Copy link
Contributor Author

Thanks @brenogazzola , I see. OK sure, I have my notes from when I did the migration, I will flesh it out into a guide for review. In the mean time should I close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants