-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBuilder Template Test failing on CI #540
Comments
Thanks @stefannibrasil for reporting this issue. The issue relates to upstream rails, a change on that end caused jbuilder to break. I did a git bisect and it looks related to the changes in rails/rails#45614 |
hi @hahmed thank you for doing that! I'm not sure what would be the next step. Perhaps creating an issue on Rails? Thank you! |
So it looks like the rails commit is something we want to keep, which means jbuilder tests will need fixing. I tested jbuilder in an app and it looks to be working fine, it's only the tests. Specifically the way it's setup to use ActionView. |
So rails/rails#46298 makes the jbuilder test suite pass on rails_head. I'm waiting to see if it doesn't break anything on the Rails side though. The Action View test suite passes, but that doesn't mean a lot. |
thank you, @casperisfine 🎉 |
The CI is returning the following error for Ruby >= 2.7:
The CI is failing even when no code changes were made. I don't have a lot of context about JBuilder and can't provide more details. I hope opening an Issue is okay. Thanks!
The text was updated successfully, but these errors were encountered: