Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amount_for_fees to EventPaymentSentSuccess #5186

Open
Tracked by #6543
LefterisJP opened this issue Oct 31, 2019 · 1 comment
Open
Tracked by #6543

Add amount_for_fees to EventPaymentSentSuccess #5186

LefterisJP opened this issue Oct 31, 2019 · 1 comment
Labels
Component / API Issues that relate the the APIs Raiden provides. Component / State Machine Flag / Usability Tag / Good First Issue

Comments

@LefterisJP
Copy link
Contributor

Problem Definition

As also seen from this issue when a payment is succesfully sent and has had fees paid the amount of the event is only the amount transferred without the fees.

That is really confusing. When the user sees this he think okay I spent 1000 tokens. But then his balance got reduced by 1012 tokens and he thinks a bug made his lose money!!!

Task

Add the amount_for_fees as a field of the EventPaymentSentSuccess. This way users who consume the event from the API will have all the information they need about the payment that happened and will not be surprised.
@LefterisJP LefterisJP added Flag / Usability Component / API Issues that relate the the APIs Raiden provides. Component / State Machine labels Oct 31, 2019
@LefterisJP LefterisJP mentioned this issue Nov 1, 2019
Closed
@ezdac ezdac mentioned this issue Nov 5, 2020
Open
9 tasks
@RyanRussell00
Copy link

@ezdac Is this still an open issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component / API Issues that relate the the APIs Raiden provides. Component / State Machine Flag / Usability Tag / Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakanalh @LefterisJP @RyanRussell00