Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release process should check the onchain code #1308

Closed
pirapira opened this issue Oct 23, 2019 · 1 comment
Closed

Release process should check the onchain code #1308

pirapira opened this issue Oct 23, 2019 · 1 comment
Labels
efforts: a few hours hack enhancement New feature or request

Comments

@pirapira
Copy link
Contributor

pirapira commented Oct 23, 2019 •
edited
Loading

raiden does not run when there is a difference between

  • data_X/contracts.json's bin-runtime
  • what's deployed at data_X/deployment*.json

However, our CI doesn't find such differences.

Maybe the release procedure should contain a step to find such a discrepancy.
@pirapira pirapira changed the title CI does not check the onchain code Release process should check the onchain code Oct 23, 2019
@pirapira pirapira added P1 urgent, blocker, or makes life easier forever efforts: a few hours hack labels Oct 23, 2019
@Dominik1999 Dominik1999 added enhancement New feature or request and removed P1 urgent, blocker, or makes life easier forever labels Mar 30, 2020
@Dominik1999
Copy link

We will close this since we test that before we release any new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efforts: a few hours hack enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirapira @Dominik1999