Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MonitoringService and OneToN should check if the service is registered #1147

Closed
pirapira opened this issue Jul 29, 2019 · 1 comment · Fixed by #1163
Closed

MonitoringService and OneToN should check if the service is registered #1147

pirapira opened this issue Jul 29, 2019 · 1 comment · Fixed by #1163
Assignees
@pirapira
Labels
P1 urgent, blocker, or makes life easier forever
Milestone
Alderaan

Comments

@pirapira
Copy link
Contributor

This issue keeps track of making sure that the MonitoringService and OneToN contracts work only for service providers that are registered in the ServiceRegistry contract.
@pirapira pirapira added this to the next mainnet deployment milestone Jul 29, 2019
@pirapira pirapira added the P1 urgent, blocker, or makes life easier forever label Jul 30, 2019
@pirapira pirapira mentioned this issue Jul 30, 2019
Merged
@pirapira pirapira self-assigned this Jul 30, 2019
@pirapira
Copy link
Contributor Author

MonitoringService.monitor() should work only for a registered service provider. MonitoringService.claimReward() can be called by anybody (maybe by a service provider whose registration has expired).

The other way around doesn't make sense. A random service provider can call monitor() many times, and then they can register later when they want to claim the reward.

@pirapira pirapira mentioned this issue Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirapira pirapira

Labels
P1 urgent, blocker, or makes life easier forever
Projects
None yet
Milestone
Alderaan
1 participant
@pirapira