-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for other device types and brands #25
Comments
Just tested with requesting for multiple product IDs. I guess we can just shotgun out a list of known product IDs in the request as long as the product IDs are constant.
which returns
|
can you please confirm whether it's working? thanks |
@sjtrny any updates? Thanks |
Nope not working. I deleted everything and installed fresh. Adding the integration proceeds successfully but no entities/devices are created. There aren't any errors in the logs though. |
Released v3.0.9 with your product, pls test and let me know if it works thanks |
@sjtrny can you pls update? Thanks |
I've updated to v3.0.10 and it kind of works.
I think this is because my unit is a hot water heater unit rather than a pool heater. |
Can you share the diagnostic details? In addition, what is the expectation in terms of the name vs. actual, same for expectation from entity to be presented vs. actual Thanks |
Missing entities that I care about:
.. and the list goes on. I think it would be better to have support for different device types that use different entity lists. Even better if we could have a seperate Python package with those definitions and have the integration translate between HASS and the package as recommended by HASS docs:
|
managed to understand how to read the parameters dynamically, it seems that there are 6 types of devices that each of them consumes parameter with different IDs, I have all the mapping thanks for the tip about the password of parameters. I will map it and most likely you will get all the entities. |
can you pls post the login request (mask the email / password) from packet sniffer, I'm trying to understand the logic of choosing the parameters the app is using thanks |
Here's the login request
and the response
|
Not sure if this helps but here's the request to get all the params
and response
|
While I’m here - this integration should probably be renamed if there is support for other products. I’d suggest using the manufacturer’s name PHNIX instead. |
it seems that your app requesting from different url (/crmservice/api/app/device/getDataByCode vs cloudservice/api/app/device/getDataByCode.json) can you please write its name? |
Hitemp. I mentioned it in the first post in this thread. |
Missed it, will investigate it further |
extracted all parameter list from the mobile app, but since I don't have supporting device I will need some screenshots to define you parameters correctly, can you please take a screenshot of each letter in the parameter settings (using code 022 and afterwards 066)? thanks |
created new beta version v3.0.11b, Per product IDAdditional components are according to following mapping:
Note: If mapping for your device are incorrect, please follow the steps below before reporting an issue:
Attach the following details to issue:
In addition, create a discord channel for faster support and discussion - https://discord.gg/6B6fakaK |
investigating more you device made me understand it works differently than AquaTemp, |
I haven't tested v3.0.11b yet. Probs not worth it until parameters are mapped. Info below. Parameter PagesMode ChangeMode list:
RequestThis example sets device to mode 0 i.e. "Intelligent mode".
Response
Temp ChangeI found that adjusting temperature in each mode was the same request regardless of the mode. Request
Response
|
Thanks for the details, really aligned with what I have saw, 3.0.11c (will be released soon) might be usefull gor you as result of it, 0: "Intelligent mode" HvacModes in HA: In addition, can you pls post a request to change fan mode (if supported)? |
ModesIt should be mapped to the Water Heater entity type not HVAC https://developers.home-assistant.io/docs/core/entity/water-heater#states 0: "Intelligent mode" -> Extra featuresChange electric element state manually
Change fan state manually
|
Was not familiar with that entity, make more sense, |
Water heater doesn't support fan speed, should it be another fan entity, What do you think about it? |
To be honest there’s no real reason to control the fan speed. It’s the fan speed for the condenser coils and should only be controlled by the device’s internal controller. It’s the equivalent of controlling the fan on your fridge’s condenser coils - pointless! I think it’s just been lazily left in the app by the developer. Similar argument applies to the electric element. You can immediately turn it on (if below target temp) by selecting fast heating mode. Overall I’d much rather abandon those two controls and have the device correctly mapped to the water heater type. |
not accurate (at least for me), I agree that most of the time it should be on auto state, with the climate control, you can turn off or on to the specific mode you would like, or just play with them, working on the support for you device |
released v3.0.11c for testing, can you please update and let me know if it works for you? |
I removed the device, downloaded 3.0.11c, restarted and tried to add the device. On the login popup I get the message "Unknown error occurred". Here's the exception
|
Version 3.0.11 was released with fix for that |
I tried re-installing a few times and nothing changed. I notice that on the Custom-component branch that the code hasn't changed i.e. the API manager constructor requires three parameters but only two are passed when creating it here.
|
you are correct, don't know how I missed it, sorry, fixing and releasing new version thanks |
new version v3.0.12 available with the fix |
Seems to be working. Lots of entities and they look correct but haven’t checked closely. |
ok, please let me know if it works for you, |
All seems to be working after 5 days. |
Amazing, can you pls close that issue and open issue for supporting the water heater entity? Thanks |
Hi, I'd like to propose supporting device types (water heater etc), which use the same hardware and IoT platform. For example in Australia the EvoHeat line of residential hot water heaters use the same infrastructure.
Currently setup fails for my EvoHeat unit as requests to
cloudservice/api/app/device/deviceList.json
do not return any devices inobject_result
.Example:
which returns
However I have discovered by sniffing the HTTP requests from the HiTemp app that the endpoint will return data when specifying the
product_ids
in the request body.For example here's the CURL command that I used (with x-token removed) for my EvoHeat 270 unit
which returns
The HiTemp app uses HTTP over port 84 but It does also work with HTTPS on the default port i.e. (
https://cloud.linked-go.com/
)The text was updated successfully, but these errors were encountered: