Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unimplemented esil instructions #268

Open
5 tasks
sushant94 opened this issue Jul 12, 2016 · 2 comments
Open
5 tasks

Add support for unimplemented esil instructions #268

sushant94 opened this issue Jul 12, 2016 · 2 comments
Labels
esil-rs Bugs for the esil.rs crate

Comments

@sushant94
Copy link
Collaborator

Currently the following still need to be implemented:

  • GOTO
  • TODO
  • LOOP
  • BREAK
  • $
@radare
Copy link
Collaborator

radare commented Jul 15, 2016

Max prio imho

On 12 Jul 2016, at 23:55, Sushant Dinesh [email protected] wrote:

Currently the following still need to be implemented:

GOTO
TODO
LOOP
BREAK
$

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ZhangZhuoSJTU
Copy link
Collaborator

ZhangZhuoSJTU commented Dec 25, 2017

About the unimplemented opcode, I have some ideas about them.

  • STACK: Add a public member to expose access to inside stack.
  • GOTO: After checking the source code of radare, I found nowadays ESIL guaranteed the previous opcode of GOTO must be an EConstant. So we could regard EGoto as an unary opcode. As for radeco-lib or other projects, we could add control flow edge from this token.
  • LOOP: Equal to 0,GOTO
  • TODO and BREAK: We could just throw these tokens, and in other projects like radeco-lib, adding a new function for them is the best way I could think out.
  • $ and TRAP: they are similar with above opcodes, except that they are unary opcode.
  • CLEAR: It's easy to handle, by clearing parser's stack and tstack, imo.

I would like to do this in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esil-rs Bugs for the esil.rs crate
Projects
None yet
Development

No branches or pull requests

4 participants