Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backbone Models have no method reset #10

Closed
tyler-johnson opened this issue Apr 23, 2014 · 1 comment
Closed

Backbone Models have no method reset #10

tyler-johnson opened this issue Apr 23, 2014 · 1 comment

Comments

@tyler-johnson
Copy link

Hello, I have found a bug that seems to only surface in very rare instances. Under the reset method for models, this.value.reset( object ); is used. Since this.value is a Backbone model, calling reset() will most certainly fail. I fixed this by replacing the whole function with return false;. This might not be desirable, so instead perhaps this.value.clear().set(object); would be better?

@rstacruz
Copy link
Contributor

rstacruz commented Oct 3, 2014

Thanks for the report! There's a PR for this at #12.

@rstacruz rstacruz closed this as completed Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants