From 873ec29a888fb9d6a71753b6f3b175d0ea3207dd Mon Sep 17 00:00:00 2001 From: Anh Nguyen Date: Wed, 13 Nov 2024 20:20:02 +0700 Subject: [PATCH 1/2] Add instance filtering to Erlang BEAM Grafana dashboard metrics - Updated metric expressions to include instance filtering with {instance=\"$node\"} for the following metrics: - erlang_vm_statistics_run_queues_length - erlang_vm_statistics_dirty_io_run_queue_length - erlang_vm_statistics_dirty_cpu_run_queue_length - Added 'DS_PROMETHEUS' as a templated data source variable (cherry picked from commit b9dc0ea3b48888703f71586741e76631789bc513) --- .../grafana/dashboards/Erlang-BEAM.json | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-BEAM.json b/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-BEAM.json index a5c6932f5051..0000ec71d78f 100644 --- a/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-BEAM.json +++ b/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-BEAM.json @@ -140,7 +140,7 @@ }, "disableTextWrap": false, "editorMode": "builder", - "expr": "erlang_vm_statistics_run_queues_length", + "expr": "erlang_vm_statistics_run_queues_length{instance=\"$node\"}", "fullMetaSearch": false, "includeNullMetadata": true, "instant": false, @@ -156,7 +156,7 @@ }, "disableTextWrap": false, "editorMode": "builder", - "expr": "erlang_vm_statistics_dirty_io_run_queue_length", + "expr": "erlang_vm_statistics_dirty_io_run_queue_length{instance=\"$node\"}", "fullMetaSearch": false, "hide": false, "includeNullMetadata": true, @@ -173,7 +173,7 @@ }, "disableTextWrap": false, "editorMode": "builder", - "expr": "erlang_vm_statistics_dirty_cpu_run_queue_length", + "expr": "erlang_vm_statistics_dirty_cpu_run_queue_length{instance=\"$node\"}", "fullMetaSearch": false, "hide": false, "includeNullMetadata": true, @@ -1165,6 +1165,20 @@ ], "templating": { "list": [ + { + "current": {}, + "hide": 2, + "includeAll": false, + "label": "datasource", + "multi": false, + "name": "DS_PROMETHEUS", + "options": [], + "query": "prometheus", + "refresh": 1, + "regex": "", + "skipUrlSync": false, + "type": "datasource" + }, { "current": {}, "datasource": { From 3c8db6fa72d9789d21b246484b7be8504cdc7ea2 Mon Sep 17 00:00:00 2001 From: Anh Nguyen Date: Wed, 13 Nov 2024 20:41:47 +0700 Subject: [PATCH 2/2] Update Erlang Distribution dashboard panel and instance filtering - Modified metric expression and legend format in State of distribution links - Changed panel type from 'flant-statusmap-panel' to 'status-history' for Process state (cherry picked from commit dc9311a561cdf6b1c9c8ea46e7517aa398a82025) --- .../docker/grafana/dashboards/Erlang-Distribution.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-Distribution.json b/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-Distribution.json index 3326b119261f..693572122031 100644 --- a/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-Distribution.json +++ b/deps/rabbitmq_prometheus/docker/grafana/dashboards/Erlang-Distribution.json @@ -542,10 +542,10 @@ "displayType": "Regular", "displayValueWithAlias": "Never", "editorMode": "code", - "expr": "erlang_vm_dist_node_state{peer!~\"rabbitmqcli.*\"} * on(rabbitmq_instance, job) group_left(rabbitmq_cluster) rabbitmq_identity_info{rabbitmq_cluster=\"$rabbitmq_cluster\", namespace=\"$namespace\"}", + "expr": "erlang_vm_dist_node_state{peer!~\"rabbitmqcli.*\"} * on(instance, job) group_left(rabbitmq_cluster, rabbitmq_node) rabbitmq_identity_info{rabbitmq_cluster=\"$rabbitmq_cluster\", namespace=\"$namespace\"}", "format": "time_series", "intervalFactor": 1, - "legendFormat": "{{rabbitmq_instance}} -> {{ peer }}", + "legendFormat": "{{rabbitmq_node}} -> {{ peer }}", "range": true, "refId": "A", "units": "none", @@ -2902,7 +2902,7 @@ "showExtraInfo": false, "showItems": false }, - "type": "flant-statusmap-panel", + "type": "status-history", "useMax": true, "usingPagination": false, "xAxis": {