Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbit_quorum_queue:all_replica_states doesn't handle some member states #11514

Closed
mkuratczyk opened this issue Jun 20, 2024 · 0 comments · Fixed by #11515
Closed

rabbit_quorum_queue:all_replica_states doesn't handle some member states #11514

mkuratczyk opened this issue Jun 20, 2024 · 0 comments · Fixed by #11515
Assignees
Labels

Comments

@mkuratczyk
Copy link
Contributor

Describe the bug

ra_state may contain a QQ state such as {'foo',init,unknown}. Currently all_replica_states doesn't map such states to a 2-tuple which leads to a crash in maps:from_list because a 3-tuple can't be handled.

A crash in rabbit_quorum_queue:all_replica_states leads to no results being returned from a given node when the CLI asks for QQs with minimum quorum.

Ultimately, the effect is that many/all quorum queues may be considered at risk of losing quorum, because we are missing data from some of the nodes.

Reproduction steps

Run rabbitmq-queues check_if_node_is_quorum_critical on a cluster with some queues in an init/unknown state.

Expected behavior

Queues in an unhealthy state should be treated as at-risk of losing quorum but should not prevent that data about other queues from being returned.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant