From d0686ff6b3ac17830209e5baf25e1f5fc29c129e Mon Sep 17 00:00:00 2001 From: Rin Kuryloski Date: Tue, 16 Apr 2024 13:11:55 +0200 Subject: [PATCH] Ignore dialyze errors for rabbitmq_ct_helpers & trust_store_http in make as we do in bazel --- .github/workflows/test-make.yaml | 1 + .github/workflows/test-plugin-make.yaml | 3 +++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/test-make.yaml b/.github/workflows/test-make.yaml index 6bf82b8c99a4..11b1547e961a 100644 --- a/.github/workflows/test-make.yaml +++ b/.github/workflows/test-make.yaml @@ -65,6 +65,7 @@ jobs: trc: /home/runner/test-result-cache hash: ${{ needs.load-test-result-cache.outputs.hash }} plugin: ${{ matrix.plugin }} + ignore-dialyze-errors: ${{ matrix.plugin == 'rabbitmq_ct_helpers' || matrix.plugin == 'trust_store_http' }} test-rabbit: needs: - load-test-result-cache diff --git a/.github/workflows/test-plugin-make.yaml b/.github/workflows/test-plugin-make.yaml index 96786ef24d1e..afd9c2b07b4d 100644 --- a/.github/workflows/test-plugin-make.yaml +++ b/.github/workflows/test-plugin-make.yaml @@ -11,6 +11,8 @@ on: plugin: required: true type: string + ignore-dialyze-errors: + type: boolean jobs: test: name: Test @@ -66,6 +68,7 @@ jobs: make -C deps/${{ inputs.plugin }} \ dialyze \ RABBITMQ_METADATA_STORE=${{ matrix.metadata_store }} + continue-on-error: ${{ inputs.ignore-dialyze-errors }} - name: EUNIT ${{ inputs.plugin }} if: steps.check.outputs.passed != 'true' run: |