-
Notifications
You must be signed in to change notification settings - Fork 166
Include password hashing function into definitions #117
Comments
Note: if we can make upgrading via definitions import smooth for |
Sorry, I'm not being specific enough: the definitions exported from
If there is no way to tell 3.5.x definitions from 3.6.0, we should do the latter and continue advising @hairyhum let me know if the above isn't clear. |
Someone suggests that if a hashing module value is missing, we should use the server default. Which makes total sense :) |
So |
Unless we can tell a JSON export file produced by 3.5.7 from the one produced by 3.6.0, yes. |
This won't help existing users < 3.6.0, however it would be a great idea to add a version to your definition exports (and to go one further, HTTP headers in your API responses) such that special cases like this could be more easily handled in the future. |
That's the point: we need to make sure the same issue doesn't pop up in the future. |
Because definitions include RabbitMQ version we managed to cover versions from 3.0.0 through 3.5.7 and 3.6.0. Good job, @hairyhum. |
…and use it during definitions import.
The idea was brought up in #116 but in a different context. It's not so much about those upgrading from 3.5.x — we have a documented procedure for them — but for those who will use a non-default function on 3.6.0+ and perform imports.
The text was updated successfully, but these errors were encountered: