New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation #89

Closed

Tv0ridobro opened this issue May 31, 2022 · 0 comments · Fixed by #90

Assignees

Tv0ridobro commented May 31, 2022

I notice that this docs are copy pasted from Channel.NotifyClose method, but receiver didn't change, so it should be Connection insted of Channel

amqp091-go/connection.go

Lines 284 to 288 in 8b6de9a

    
           The chan provided will be closed when the Channel is closed and on a 
        
           graceful close, no error will be sent. 
        
           In case of a non graceful close the error will be notified synchronously by the library 
        
           so that it will be necessary to consume the Channel from the caller in order to avoid deadlocks

Zerpet self-assigned this

Zerpet mentioned this issue

Update connection documentation #90

Merged

michaelklishin closed this as completed in #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment