Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect_match gives failure, but no info, when object is zero length #867

Closed
jackwasey opened this issue Apr 19, 2019 · 0 comments
Closed
Labels
expectation 🙀 feature a feature request or enhancement

Comments

@jackwasey
Copy link

If the object for expect_match is zero length, the test fails, but info is not reported. Contrast with expect_equal, when info is reported.

expect_match(character(0), "regex", info = "my info")
expect_equal(character(0), "regex", info = "my info")

Expected: if object is zero length, the user's info string should be used, in line with other testthat expectations.

Maybe related to #100

@hadley hadley added expectation 🙀 feature a feature request or enhancement labels Apr 23, 2019
@hadley hadley closed this as completed in 9029373 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expectation 🙀 feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants