From 58af0b34470399d3b109809ce20cb3c070753fe2 Mon Sep 17 00:00:00 2001 From: Hadley Wickham Date: Tue, 17 Sep 2024 14:16:25 -0500 Subject: [PATCH] Check revdeps And update docs about new evaluation strategy in light of failure. --- NEWS.md | 4 +-- R/profvis.R | 3 ++- cran-comments.md | 37 ++++++++-------------------- man/profvis.Rd | 3 ++- revdep/.gitignore | 1 + revdep/README.md | 30 +++-------------------- revdep/cran.md | 16 ++++++++++++ revdep/problems.md | 61 +++++++++++++++++++++++++++++++++++++++++++++- 8 files changed, 97 insertions(+), 58 deletions(-) create mode 100644 revdep/cran.md diff --git a/NEWS.md b/NEWS.md index 24fc0909..3dd9a10b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -9,8 +9,8 @@ stack (#130). This requires a new evaluation model where the code you supply to `profvis()` is turned into the body of a zero-argument anonymous function that is then called by profvis. This subtly changes the semantics of - evaluation, but it's very unlikely to affect the type of code that you are - typically profiling. + evaluation, but the primary effect is that if you create variables inside of + the profiled code they will no longer be available outside of it. * `profvis()` now uses elapsed time where possible (#72). diff --git a/R/profvis.R b/R/profvis.R index 02c45239..c62325b9 100644 --- a/R/profvis.R +++ b/R/profvis.R @@ -10,7 +10,8 @@ #' #' @param expr Expression to profile. The expression will be turned into the #' body of a zero-argument anonymous function which is then called repeatedly -#' as needed. +#' as needed. This means that if you create variables inside of `expr` they +#' will not be available outside of it. #' #' The expression is repeatedly evaluated until `Rprof()` produces #' an output. It can _be_ a quosure injected with [rlang::inject()] but diff --git a/cran-comments.md b/cran-comments.md index 5baf2c57..3705014e 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,37 +1,20 @@ ## Comments -### May 14, 2019 - -Submitting small enhancements. Please let me know if there is anything I can do. - -Thank you for your time, -- Winston - - -## Test environments -* local OS X install, R 3.6.0 -* travis-ci ubuntu 14.04 - * R 3.5.3 - * R 3.6.0 - * R Under development (unstable) (2019-05-13 r76492) -* win-builder (devel and release) - * R version 3.5.3 (2019-03-11) - * R version 3.6.0 (2019-04-26) - * R Under development (unstable) (2019-05-12 r76489) -* rhub - * Windows Server 2008 R2 SP1, R-devel, 32/64 bit - * Ubuntu Linux 16.04 LTS, R-release, GCC - * Fedora Linux, R-devel, clang, gfortran - * Debian Linux, R-devel, GCC ASAN/UBSAN - ## R CMD check results 0 errors | 0 warnings | 0 notes - ## revdepcheck results -We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. +We checked 8 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. - * We saw 0 new problems + * We saw 1 new problems * We failed to check 0 packages + +Issues with CRAN packages are summarised below. + +### New problems +(This reports the first line of each new failure) + +* tidyft + Patch submitted at https://github.com/hope-data-science/tidyft/pull/4 diff --git a/man/profvis.Rd b/man/profvis.Rd index 6a02e20c..b189065c 100644 --- a/man/profvis.Rd +++ b/man/profvis.Rd @@ -21,7 +21,8 @@ profvis( \arguments{ \item{expr}{Expression to profile. The expression will be turned into the body of a zero-argument anonymous function which is then called repeatedly -as needed. +as needed. This means that if you create variables inside of \code{expr} they +will not be available outside of it. The expression is repeatedly evaluated until \code{Rprof()} produces an output. It can \emph{be} a quosure injected with \code{\link[rlang:inject]{rlang::inject()}} but diff --git a/revdep/.gitignore b/revdep/.gitignore index 31f6c40d..bc768ae1 100644 --- a/revdep/.gitignore +++ b/revdep/.gitignore @@ -4,3 +4,4 @@ checks.noindex library.noindex data.sqlite *.html +cloud.noindex diff --git a/revdep/README.md b/revdep/README.md index 40da4a17..dbc5c8b5 100644 --- a/revdep/README.md +++ b/revdep/README.md @@ -1,30 +1,8 @@ -# Platform - -|field |value | -|:--------|:----------------------------| -|version |R version 3.6.0 (2019-04-26) | -|os |macOS Mojave 10.14.4 | -|system |x86_64, darwin15.6.0 | -|ui |X11 | -|language |(EN) | -|collate |en_US.UTF-8 | -|ctype |en_US.UTF-8 | -|tz |America/New_York | -|date |2019-05-14 | - -# Dependencies - -|package |old |new |Δ | -|:-------|:-----|:-----|:--| -|profvis |0.3.5 |0.3.6 |* | - # Revdeps -## All (3) +## New problems (1) -|package |version |error |warning |note | -|:------------|:-------|:-----|:-------|:----| -|gtable |0.3.0 | | | | -|RobinHood |1.0.5 | | | | -|SpaDES.tools |0.3.2 | | | | +|package |version |error |warning |note | +|:-------|:-------|:------|:-------|:--------| +|[tidyft](problems.md#tidyft)|0.5.7 |__+1__ | |1 __+1__ | diff --git a/revdep/cran.md b/revdep/cran.md new file mode 100644 index 00000000..de0e5443 --- /dev/null +++ b/revdep/cran.md @@ -0,0 +1,16 @@ +## revdepcheck results + +We checked 8 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. + + * We saw 1 new problems + * We failed to check 0 packages + +Issues with CRAN packages are summarised below. + +### New problems +(This reports the first line of each new failure) + +* tidyft + checking running R code from vignettes ... ERROR + checking re-building of vignette outputs ... NOTE + diff --git a/revdep/problems.md b/revdep/problems.md index 9a207363..2dc4229f 100644 --- a/revdep/problems.md +++ b/revdep/problems.md @@ -1 +1,60 @@ -*Wow, no problems at all. :)* \ No newline at end of file +# tidyft + +
+ +* Version: 0.5.7 +* GitHub: https://github.com/hope-data-science/tidyft +* Source code: https://github.com/cran/tidyft +* Date/Publication: 2023-01-08 14:40:01 UTC +* Number of recursive dependencies: 47 + +Run `revdepcheck::cloud_details(, "tidyft")` for more info + +
+ +## Newly broken + +* checking running R code from vignettes ... ERROR + ``` + Errors in running code in vignettes: + when running code in ‘Introduction.Rmd’ + ... + + > profvis({ + + res1 = ft %>% select_fst(Species, Sepal.Length, Sepal.Width, + + Petal.Length) %>% dplyr::select(-Petal.Length) %>% dplyr::re .... [TRUNCATED] + + > setequal(res1, res2) + + When sourcing ‘Introduction.R’: + Error: object 'res1' not found + Execution halted + + ‘Introduction.Rmd’ using ‘UTF-8’... failed + ``` + +* checking re-building of vignette outputs ... NOTE + ``` + Error(s) in re-building vignettes: + ... + --- re-building ‘Introduction.Rmd’ using rmarkdown + + Quitting from lines 113-183 [unnamed-chunk-5] (Introduction.Rmd) + Error: processing vignette 'Introduction.Rmd' failed with diagnostics: + object 'res1' not found + --- failed re-building ‘Introduction.Rmd’ + + SUMMARY: processing the following file failed: + ‘Introduction.Rmd’ + + Error: Vignette re-building failed. + Execution halted + ``` + +## In both + +* checking Rd cross-references ... NOTE + ``` + Packages unavailable to check Rd xrefs: ‘tidyfst’, ‘tidyr’, ‘fastDummies’ + ``` +