Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout submodules by default? #15

Closed
andrjohns opened this issue May 12, 2024 · 2 comments
Closed

Checkout submodules by default? #15

andrjohns opened this issue May 12, 2024 · 2 comments

Comments

@andrjohns
Copy link

Loving the new Github actions approach to rhub! One request, could the r-hub/actions/checkout@v1 action checkout submodules by default? Or have an option to enable?

Thanks!

@gaborcsardi
Copy link
Contributor

We can certainly forward options to actions/checkout. I am no sure if it should be the default, I would lean towards no, because it is not the default in actions/checkout.

We'll have a way to set additional parameters at the time of submission, or in the config of the R package, so that people don't need to change the R-hub workflow file. But it is also OK to change it, I think.

@gaborcsardi
Copy link
Contributor

Done in 72ea641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants