Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN error #21

Closed
LucyMcGowan opened this issue Jan 31, 2024 · 7 comments
Closed

CRAN error #21

LucyMcGowan opened this issue Jan 31, 2024 · 7 comments

Comments

@LucyMcGowan
Copy link
Collaborator

@malcolmbarrett I got an email this morning that we need to make an updated in order to stay on CRAN based on an error on one of their checks:

https://cran.r-project.org/web/checks/check_results_tipr.html

It looks like it is only seen on one machine:

Version: 1.0.1
Check: examples
Result: ERROR
Running examples in ‘tipr-Ex.R’ failed
The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")
### Name: adjust_hr
### Title: Adjust an observed hazard ratio for a normally distributed
###   confounder
### Aliases: adjust_hr adjust_hr_with_continuous

### ** Examples

adjust_hr(0.9, -0.9, 1.3) 

Error in eval(call("force", as.symbol(paste0("..", x)))) :
argument "..8" is missing, with no default
Calls: adjust_hr ... glue_data -> lapply -> FUN -> %||% -> eval -> eval -> force
Execution halted
Flavor: r-devel-linux-x86_64-debian-gcc

I can't seem to replicate it myself on my machine -- do you have an ideas on how we might fix this? (maybe we can chat on our next call)

@malcolmbarrett
Copy link
Contributor

It seems to be propogating on the devel version -- four errors now! I can try to install that version of R locally to see if I can replicate it. In the meantime, I ran

library(tipr)
debug(glue::glue_data)
adjust_hr(0.9, -0.9, 1.3)
undebug(glue::glue_data)

But the information I got from it was limited. It seems to me like it's from the cli call

@malcolmbarrett
Copy link
Contributor

It might be helpful to post on the cli repo if so

@malcolmbarrett
Copy link
Contributor

This seems to be an r-devel issue, but I can't replicate it locally using R-devel for mac 🤔

@malcolmbarrett
Copy link
Contributor

Ah! It's a glue issue about trailing commas tidyverse/glue#320

@malcolmbarrett
Copy link
Contributor

malcolmbarrett commented Feb 6, 2024

Except I can't find any in tipr on a first pass 🙃. Maybe the error is being triggered in another way? I am able to replicate the error in the linked issue, so at least there is that

@malcolmbarrett
Copy link
Contributor

There are a lot of changes here since the last CRAN release, so I'm going try running the dev version on CRAN's windows devel machine

@malcolmbarrett
Copy link
Contributor

I can finally replicate this using the CRAN version of tipr. Pretty sure we've already fixed it and just need to do a release 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants