Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move composite addon with all issues to standalone repo #419

Closed
jzaefferer opened this issue Mar 3, 2013 · 3 comments
Closed

Move composite addon with all issues to standalone repo #419

jzaefferer opened this issue Mar 3, 2013 · 3 comments

Comments

@jzaefferer
Copy link
Member

@JamesMGreene is this something you could take care of? Follow what @Krinkle did for the JUnit addon, except for issues. Those should be filed with all details in the new repo and closed here.

@jzaefferer
Copy link
Member Author

The repo is here: https://github.com/jquery/qunit-composite

@JamesMGreene
Copy link
Member

Yup, I'm planning on tackling this. Unfortunately, we can't just move the files for this one as Composite doesn't yet have any legitimate unit tests of its own yet and therefore expects QUnit core and the other addons to be present in order to run their test suites as its own unit tests (which misses a ton of edge cases that I'd like to test for anyway).

@Krinkle and I discussed how to unit test this one for a few minutes... believe I will basically have to follow QUnit core's test suite model of running tests and then verifying their results. Sound about right?

@ghost ghost assigned JamesMGreene Mar 3, 2013
@jzaefferer
Copy link
Member Author

You could include QUnit as a submodule for running those tests. Or install via npm and link to node_modules/qunitjs/... (something I've been meaning to try anyway).

I don't have much input on the tests itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants