make sure ql-active gets set on toolbar checklist buttons #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This limitation is why checklists are not yet officially released. While your approach probably works it involves hard-coding and would prefer to solve it more generally by adding flexibility to the keyboard module itself. |
This was referenced Apr 24, 2020
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
{list: 'check'}toolbar buttons don't get.ql-activewhen the selection is over a checklist. This is because the format of checklists is eithercheckedorunchecked, rather than matching the toolbar button value like most other formats.This PR fixes this issue by looking up the correct format value before checking against the button value.
Thanks for your awesome work on Quill ✨🌟