registry: add support for extended repository names (PROJQUAY-1535) #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillDett
reviewed
Jun 28, 2021
util/names.py
Outdated
|
|
||
| # Extended repostitory name regex: allows "/" in repo names | ||
| REPOSITORY_NAME_EXTENDED_REGEX = re.compile( | ||
| "^(?=.{0,255}$)[a-z0-9][\.a-z0-9_-]*(?:\/[a-z0-9][\.a-z0-9_-]*)*$" |
There was a problem hiding this comment.
@kleesc - should this be a raw string (r"...") as well like the REPOSITORY_NAME_REGEX?
kleesc
force-pushed
the
extended-repo-names
branch
2 times, most recently
from
c6de924 to
dd3b2c1
Compare
kleesc
force-pushed
the
extended-repo-names
branch
25 times, most recently
from
a461e52 to
2d4dc7a
Compare
kleesc
force-pushed
the
extended-repo-names
branch
from
2d4dc7a to
ddd8f71
Compare
thomasmckay
suggested changes
Jul 15, 2021
kleesc
force-pushed
the
extended-repo-names
branch
3 times, most recently
from
18ae3d3 to
5fc803c
Compare
jonathankingfc
previously approved these changes
Jul 23, 2021
kleesc
force-pushed
the
extended-repo-names
branch
from
5fc803c to
a8eb651
Compare
jonathankingfc
previously approved these changes
Jul 28, 2021
Allows forward slashes to be used in repository names according to https://docs.docker.com/docker-hub/repos/. NOTE: This change simply allows the use of "/" in repository names needed for certain Openshift use cases. This does not implement any new permission model for nested paths. i.e A repository with a nested path is treated as a single repository under a _single_ namespace.
kleesc
force-pushed
the
extended-repo-names
branch
from
a8eb651 to
2945603
Compare
jonathankingfc
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows forward slashes to be used in repository names according to
https://docs.docker.com/docker-hub/repos/.
NOTE: This change simply allows the use of "/" in repository
names needed for certain Openshift use cases. This does not implement
any new permission model for nested paths. i.e A repository with a
nested path is treated as a single repository under a single
namespace.